Re: Code Review Request, JDK-8219991 : New fix of the deadlock in sun.security.ssl.SSLSocketImpl

2019-05-05 Thread Alan Bateman
On 05/05/2019 16:18, Xuelei Fan wrote: All good catches! I made the update accordingly.  Here is the new webrev:   http://cr.openjdk.java.net/~xuelei/8219991/webrev.03/ This update looks okay to me (an aternative for read is a nested try/finally but what you have is okay). -Alan

Re: Code Review Request, JDK-8219991 : New fix of the deadlock in sun.security.ssl.SSLSocketImpl

2019-05-05 Thread Xuelei Fan
All good catches! I made the update accordingly. Here is the new webrev: http://cr.openjdk.java.net/~xuelei/8219991/webrev.03/ Thanks, Xuelei On 5/3/2019 11:27 PM, Alan Bateman wrote: On 04/05/2019 02:23, Xuelei Fan wrote: Hi, There is a surprise in the regression test.  I made the update

Re: RFR 6722928: Support SSPI as a native GSS-API provider

2019-05-05 Thread Weijun Wang
Hi Michael and Nico, > > sspi.cpp: > * KRB5_TRACE If you think a different name is better I'll change it. And then I'd like to revert to my old code that it always print to stderr. I don't have a need to print it to any file. > * showTime(): please use a readable format akin to %FT%T What is