Oops, forgot to add the bug title in the subject.
> On Jun 11, 2019, at 11:56 AM, Weijun Wang wrote:
>
> Please take a review at
>
> https://cr.openjdk.java.net/~weijun/8225180/webrev.00
>
> I added some extra info into the exception message not realizing it will be a
> bug. Revert back to
Please take a review at
https://cr.openjdk.java.net/~weijun/8225180/webrev.00
I added some extra info into the exception message not realizing it will be a
bug. Revert back to previous code.
Thanks,
Max
> On Jun 11, 2019, at 12:15 AM, Erik Joelsson wrote:
>
> Hello Max,
>
> I believe $(call FindSrcDirsForLib, $(MODULE), sspi_bridge) for SRC is the
> default so you shouldn't need to specify it explicitly, or did you experience
> some problems with the default that I'm missing?
I don't reme
On Mon, Jun 10, 2019 at 10:30:50AM +0800, Weijun Wang wrote:
> Updated webrev at
>
>http://cr.openjdk.java.net/~weijun/6722928/webrev.08/
-
src/java.security.jgss/share/classes/sun/security/jgss/spnego/NegTokenTarg.java
Ugh, I never noticed GSSUtil.useMSInterop(). This really should no
Hi Max,
Thanks for the clarification on DecryptMessage. Updated webrev looks fine.
Regards,
Valerie
On 6/9/2019 7:30 PM, Weijun Wang wrote:
Updated webrev at
http://cr.openjdk.java.net/~weijun/6722928/webrev.08/
@build-dev guys, I realize I've never included you in this code review. Plea
Hi Jamil,
Sure, I will add these two OIDs as well. If there is discussion on oid
registry, I'd like to join to explore potential ideas.
Will re-test w/ mach5 and update the webrev in place and integrate once
the mach5 job is finished.
Thanks!
Valerie
On 6/10/2019 9:07 AM, Jamil Nimeh wrote:
Hello Max,
I believe $(call FindSrcDirsForLib, $(MODULE), sspi_bridge) for SRC is
the default so you shouldn't need to specify it explicitly, or did you
experience some problems with the default that I'm missing?
/Erik
On 2019-06-09 19:30, Weijun Wang wrote:
Updated webrev at
http://cr
Hi Valerie,
Sorry I didn't answer your question regarding where I found the
dsa-with-sha384 and dsa-with-sha512 OIDs. I usually check OIDs from
http://www.oid-info.com. I grabbed the OID without the leaf node
(2.16.840.1.101.3.4.3) and checked your sha224 and sha256, which were
correct. Th
On 6/10/19 8:59 AM, Michael Osipov wrote:
> Do I have still have some time to test this in our multi-forest
> environment? I have a large setup to "play" with.
>
This would be great. Thanks.
> On Jun 10, 2019, at 7:59 PM, Michael Osipov <[email protected]> wrote:
>
> Am 2019-04-23 um 06:53 schrieb Weijun Wang:
>> Hi Martin,
>>
>> Sorry for the delay. I went through the changes and they are all in the
>> correct place. Next, I'll read the RFC carefully and make sure all behaviors
Am 2019-04-23 um 06:53 schrieb Weijun Wang:
Hi Martin,
Sorry for the delay. I went through the changes and they are all in the correct
place. Next, I'll read the RFC carefully and make sure all behaviors are
correct. In the mean time, you can start preparing the CSR.
BTW, what kinds of real w
One final question.
I'm not familiar with TestNG but it looks like "import static
org.testng.Assert.*" is not used. Can I remove it?
Thanks,
Max
> On Jun 9, 2019, at 5:16 PM, Philipp Kunz wrote:
>
> Hi Max,
>
> Thanks for removing the unnecessary imports.
>
> Before moving the @test comment
12 matches
Mail list logo
