Re: [13] RFR 8228342: Add SignTwice.java to problem list

It looks good to me. Xuelei On 7/17/2019 6:18 PM, Weijun Wang wrote: The new test included in JDK-8217375 fails intermittently on Windows so it was put into problem list at adding time, but I mistakenly use 8217375 in the entry. I've just created 2 new issues: 8228341: SignTwice.java fails i

[13] RFR 8228342: Add SignTwice.java to problem list

The new test included in JDK-8217375 fails intermittently on Windows so it was put into problem list at adding time, but I mistakenly use 8217375 in the entry. I've just created 2 new issues: 8228341: SignTwice.java fails intermittently on Windows 8228342: Add SignTwice.java to problem list Her

Re: RFR 8227437: S4U2proxy cannot continue because server's TGT cannot be found

Update the copyright year of the 2 C files to 2019 and you can push the change. Thanks, Max > On Jul 18, 2019, at 12:07 AM, Martin Balao wrote: > > On 7/17/19 4:30 AM, Weijun Wang wrote: >> There is still a kerberosTicketSetClientAlias() call in >> Krb5LoginModule.java. Otherwise looks fine. >

Re: RFR: 8228337: problemList failing/ignored manual tests in security-libs

On 7/17/19 3:40 PM, Rajan Halade wrote: Please review this problemList update to add earlier ignored manual regression tests. These tests require special setup/hardware and few have outdated JDK and need update. webrev: http://cr.openjdk.java.net/~rhalade/8228337/webrev.00/ Thanks, Rajan L

RFR: 8228337: problemList failing/ignored manual tests in security-libs

Please review this problemList update to add earlier ignored manual regression tests. These tests require special setup/hardware and few have outdated JDK and need update. webrev: http://cr.openjdk.java.net/~rhalade/8228337/webrev.00/ Th

Re: RFR 8226338: Updates to Stateless Resumption

FInished up with .03, looks good! --Jamil On 7/2/19 10:35 AM, Anthony Scarpino wrote: Hi, I need a code review on some updates to the stateless resumption. 1) Changing peerSupportedSignAlgs from a String[] to Collection[] 2) Additional items added to the stateless ticket 3) Not provide a stat

Re: RFR[13]: 8227551 Session Resumption without Server-Side State off by default

I'm going to take a suggestion posted by Jamil privately to instead use statelessSession = Boolean.parseBoolean(st); Given it's a one liner and the tests have all passed, I'm not going to repost the webrev Tony On 7/16/19 8:43 PM, [email protected] wrote: Hi Tony, Just a minor commen

Re: RFR 8227437: S4U2proxy cannot continue because server's TGT cannot be found

On 7/17/19 4:30 AM, Weijun Wang wrote: > There is still a kerberosTicketSetClientAlias() call in Krb5LoginModule.java. > Otherwise looks fine. > Hi Max, Missed that one. Fixed at: http://cr.openjdk.java.net/~mbalao/webrevs/8227437/8227437.webrev.03/ Please let me know if we are okay to go. T

Re: RFR[13]: 8227551 Session Resumption without Server-Side State off by default

On 7/16/2019 8:43 PM, [email protected] wrote: Hi Tony, Just a minor comment.  242 if (st.compareToIgnoreCase("true") == 0) {  243 statelessSession = true;  244 } Could it simply use the below statement? statelessSession = st.equalsIgnoreCase("true")

Re: RFR 8227437: S4U2proxy cannot continue because server's TGT cannot be found

There is still a kerberosTicketSetClientAlias() call in Krb5LoginModule.java. Otherwise looks fine. I'll run some internal test now. Thanks, Max > On Jul 17, 2019, at 2:58 PM, Martin Balao wrote: > > Hi Max, > > Webrev.02 is ready: > http://cr.openjdk.java.net/~mbalao/webrevs/8227437/8227437