Re: RFR 8211360 : Change #if DEF to #if defined(DEF)

2019-08-20 Thread Brian Burkhalter
Hello Ivan, Looks fine. Brian > On Aug 20, 2019, at 10:38 AM, Ivan Gerasimov > wrote: > > It's a followup for JDK-8211146. > > With that fix several C-preprocessor statements of form #elif __linux__ were > changed to more accurate #elif defined(__linux__). > > grep found a few more occurre

RFR 8211360 : Change #if DEF to #if defined(DEF)

2019-08-20 Thread Ivan Gerasimov
Hello! It's a followup for JDK-8211146. With that fix several C-preprocessor statements of form #elif __linux__ were changed to more accurate #elif defined(__linux__). grep found a few more occurrences of the same pattern, which also would better be cleaned up. BUGURL: https://bugs.openjdk

Re: [RFR] JDK-8225436 : Stapled OCSPResponses should be added to PKIXRevocationChecker irrespective of revocationEnabled flag

2019-08-20 Thread Jamil Nimeh
Thanks for the review, Sean.  I've made a couple changes based on your recommendations.  I don't create a mutable ArrayList any longer in the case where we're making a new PKIXRevocationChecker.  In that one case I just directly add it to the PKIXBuilderParameters and if one already exists from