Re: RFR(T): 8230910: libsspi_bridge does not build on Windows 32bit

2019-09-14 Thread Thomas Stüfe
Thanks for the reviews, will push. ..Thomas On Fri, Sep 13, 2019 at 2:58 PM Weijun Wang wrote: > Also looks fine to me. I can confirm it also builds successfully on > windows-x64. > > Thanks, > Max > > > > On Sep 13, 2019, at 3:22 PM, Alan Bateman > wrote: > > > > > > Using size_t looks okay h

Re: RFR: 8229773: Resolve permissions for code source URLs lazily

2019-09-14 Thread Peter Firmstone
Hi Alan, We've got a bunch of very old policy files in our test suite, so they still had policy grants using the extension directory property. The grant for the extension directory property was followed by a forward slash and asterix. Oddly when the property was missing the grant became a w

Re: RFR: 8229773: Resolve permissions for code source URLs lazily

2019-09-14 Thread Alan Bateman
On 13/09/2019 23:07, Peter Firmstone wrote: : One change I noticed is permissions granted to the java extension directory are now granted to every domain in our policy provider as the java.ext.dirs property is now blank, I also had to grant permissions to a number of jdk modules, after fixing