Re: RFR [XS] 8231357: sun/security/pkcs11/Cipher/TestKATForGCM.java fails on SLES11 using mozilla-nss-3.14

2019-09-30 Thread Valerie Peng
Yes, latest webrev looks fine to me. Thanks for the update, Valerie On 9/26/2019 2:30 AM, Baesken, Matthias wrote: Hi Christoph, you are right  -  I should  better use getVersionStr()   ,  I’ll replace it . Valerie are you fine with the latest webrev ? Best regards, Matthias *From:*Langer

Re: RFR (XS) 8230415 : Avoid redundant permission checking in FilePermissionCollection and SocketPermissionCollection

2019-09-30 Thread Ivan Gerasimov
Thank you Sean for reviewing! With kind regards, Ivan On 9/27/19 7:20 AM, Sean Mullan wrote: Hi Ivan, The fix looks good. Good catch. --Sean On 8/30/19 7:32 PM, Ivan Gerasimov wrote: Hello! In the two implementations of PermissionCollection.implies(Permission), all the permissions are