Hi Ivan,
On 10/1/19 10:26 PM, Ivan Gerasimov wrote:
Hello!
The constructors of SocketPermission and FilePermission expect a
String argument with comma-separated list of actions.
If the list is malformed, then the constructors throw
IllegalArgumentException.
It turns out that the current i
Thank you Joe for checking it!
On 10/2/19 4:38 PM, Joe Darcy wrote:
Hello,
At least from a quick reading, either the spec change or the behavior
change would seem to merit a CSR.
Sigh. I was hopping it'll be a quick fix :-)
So, I filed CSR: https://bugs.openjdk.java.net/browse/JDK-8231805
During the pre-integration mach5 run, I ran into a window-specific data
alignment problem when the custom GCM param structure is declared inside
pkcs11wrapper.h in webrev.01. So, I ended up adding a separate header
file pkcs11gcm2.h containing only this structure and include it in the
platform-
Hello,
At least from a quick reading, either the spec change or the behavior
change would seem to merit a CSR.
Cheers,
-Joe
On 10/2/2019 4:26 PM, Ivan Gerasimov wrote:
Hi Chris!
Thank you very much for review!
I agree that it makes sense to update the javadoc for consistency.
I don't thi
Hi Chris!
Thank you very much for review!
I agree that it makes sense to update the javadoc for consistency.
I don't think CSR is required in this case, is it? (IAE is unchecked
anyway, and the fix doesn't really change the behavior.)
Here's the updated webrev:
http://cr.openjdk.java.net/~i
Ivan,
On 01/10/2019 21:26, Ivan Gerasimov wrote:
Hello!
The constructors of SocketPermission and FilePermission expect a String
argument with comma-separated list of actions.
If the list is malformed, then the constructors throw
IllegalArgumentException.
It turns out that the current impl