Thank you Weijun!
Pushed.
On 10/16/19 6:42 PM, Weijun Wang wrote:
The change looks fine to me.
Thanks,
Max
On Oct 17, 2019, at 9:33 AM, Ivan Gerasimov wrote:
Hello!
This is a javadoc-only cleanup.
In a few places a dash was used between the exception name and the description
under the
The change looks fine to me.
Thanks,
Max
> On Oct 17, 2019, at 9:33 AM, Ivan Gerasimov wrote:
>
> Hello!
>
> This is a javadoc-only cleanup.
>
> In a few places a dash was used between the exception name and the
> description under the @throws tag.
>
> This causes a double dash in the prod
Hello!
This is a javadoc-only cleanup.
In a few places a dash was used between the exception name and the
description under the @throws tag.
This causes a double dash in the produced documentation. For example,
see
https://docs.oracle.com/en/java/javase/12/docs/api/java.base/java/security/
Hi,
On Wed, Oct 16, 2019 at 7:42 PM Xuelei Fan wrote:
>
> Hi Simone,
>
> The compatibility impact makes sense to me. Would you mind file a new bug?
https://bugs.openjdk.java.net/browse/JDK-8232432
Thanks!
--
Simone Bordet
---
Finally, no matter how good the architecture and design are,
to del
Hi Simone,
The compatibility impact makes sense to me. Would you mind file a new bug?
Thanks,
Xuelei
On 10/16/2019 9:13 AM, Simone Bordet wrote:
Hi,
On Wed, Oct 16, 2019 at 5:42 PM Xuelei Fan wrote:
The TLS protocol was changed to use half-close policy since TLS 1.3. As
means that sslEngi
Hi,
On Wed, Oct 16, 2019 at 5:42 PM Xuelei Fan wrote:
>
> The TLS protocol was changed to use half-close policy since TLS 1.3. As
> means that sslEngine.closeOutbound() will close the outbound and keep
> the inbound open. "NEED_UNWRAP" is used to indicate that the engine can
> still be used to
The TLS protocol was changed to use half-close policy since TLS 1.3. As
means that sslEngine.closeOutbound() will close the outbound and keep
the inbound open. "NEED_UNWRAP" is used to indicate that the engine can
still be used to decode input message.
For the specific case bellow, it is rea
Looks fine to me.
--Sean
On 10/15/19 11:15 PM, Weijun Wang wrote:
http://cr.openjdk.java.net/~weijun/8232357/webrev.00/
This fix adds the version info of Santuario into the source code and also
introduces a test to ensure the version is the same with the one in the legal
notice.
Thanks,
Max
Hi,
SSLContext sslContext = SSLContext.getDefault();
SSLEngine sslEngine = sslContext.createSSLEngine();
sslEngine.closeOutbound();
SSLEngineResult.HandshakeStatus hsStatus = sslEngine.getHandshakeStatus();
System.err.println("hsStatus = " + hsStatus);
This prints "NOT_HANDSHAKING" in Java 8 and
