Everything looks fine.
But please hold on for a little while, the CSR is still not approved yet.
Thanks,
Max
> On Nov 12, 2019, at 11:38 AM, Martin Balao wrote:
>
> Hi Max,
>
> Thanks for your review.
>
> On 11/9/19 5:25 AM, Weijun Wang wrote:
>> I added my name as a CSR reviewer and your co
Hi Max,
Thanks for your review.
On 11/9/19 5:25 AM, Weijun Wang wrote:
> I added my name as a CSR reviewer and your code change looks fine.
>
> One nit, if it were me, I would throw an exception in "CLIENT" mode and let
> executeCommand() to test for .shouldHaveExitValue(0). It's up to you to
Hi,
I'd like to request a review for 8233946 [1].
Webrev.00:
* http://cr.openjdk.java.net/~mbalao/webrevs/8233946/8233946.webrev.00/
Thanks,
Martin.-
--
[1] - https://bugs.openjdk.java.net/browse/JDK-8233946
Thank you Seán for reviewing!
On 11/11/19 7:56 AM, Seán Coffey wrote:
Nice work Ivan.
I see you've some clean up done on exception handling also. I might
have a concern on this change in SSLLogger. You're catching
IOException now instead of Exception. Given that it's a logger and the
intent
Nice work Ivan.
I see you've some clean up done on exception handling also. I might have
a concern on this change in SSLLogger. You're catching IOException now
instead of Exception. Given that it's a logger and the intent seems to
be to ignore any type of exception - should we leave what's the
