Re: [14] RFR: 8233228: Support named curves for all disabledAlgorithms

More on this. I've tried using keytool to generate an EC keypair with -groupname contained in "jdk.certpath.disabledAlgorithms". It can print out a warning with the following extra code change. Feel free to include it if it looks OK to you. diff --git

Re: RFR 8234697: Generate sun.security.util.math.intpoly classes during build

> On Nov 27, 2019, at 9:44 PM, Erik Joelsson wrote: > > On 2019-11-26 16:39, Weijun Wang wrote: >> >>> On Nov 27, 2019, at 12:14 AM, Erik Joelsson >>> wrote: >>> >>> On 2019-11-25 16:42, Weijun Wang wrote: > On Nov 26, 2019, at 12:36 AM, Erik Joelsson > wrote: > > Build

Re: [14] RFR: 8233228: Support named curves for all disabledAlgorithms

In ConstraintsParameters.java: You added curveStr assignment in the ConstraintsParameters(X509Certificate,...). Is it also necessary to do the same in the next constructor ConstraintsParameters(...,Key,...)? You can get curve name from the key. Also, now that a key has a parameter that needs

Re: [14]RFR: 8234725: sun/security/ssl/SSLContextImpl tests support TLSv1.3

Looks good to me. Thanks! Xue-Lei > On Nov 27, 2019, at 3:58 AM, "sibabrata.sa...@oracle.com" > wrote: > > Hi Xuelei, > > Please review the patch for, > JBS: https://bugs.openjdk.java.net/browse/JDK-8234725 > Webrev: http://cr.openjdk.java.net/~ssahoo/8234725/webrev.00/ > > Change: > This

Re: RFR: 8233223: Add Amazon Root CA certificates

Looks good. --Sean On 11/26/19 2:07 PM, Rajan Halade wrote: May I request you to review this fix to add 4 new Amazon root certificates to cacerts. Webrev: http://cr.openjdk.java.net/~rhalade/8233223/webrev.00/ Thanks, Rajan

Re: RFR 8234697: Generate sun.security.util.math.intpoly classes during build

On 2019-11-26 16:39, Weijun Wang wrote: On Nov 27, 2019, at 12:14 AM, Erik Joelsson wrote: On 2019-11-25 16:42, Weijun Wang wrote: On Nov 26, 2019, at 12:36 AM, Erik Joelsson wrote: Build change looks good. Thanks. One question: I see the output to stdout from FieldGen.java shown in

[14]RFR: 8234725: sun/security/ssl/SSLContextImpl tests support TLSv1.3

Hi Xuelei, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8234725 Webrev: http://cr.openjdk.java.net/~ssahoo/8234725/webrev.00/ Change: This is a small change