Re: [14] RFR: 8233228: Support named curves for all disabledAlgorithms

Updated webrev: Includes java.security updates Max's addition Sean's comments http://cr.openjdk.java.net/~ascarpino/8233228/webrev.02/ Tony

Re: CSR RFR: 8233228: Support named curves for all disabledAlgorithms

On 12/10/19 5:37 PM, Anthony Scarpino wrote: I believe I have address all the comments in the updated CSR.  I have also added the "include" keyword for the new property along with the description for it's use. Great. However, regarding the brainpool curves, the ones you say that we do not su

Re: CSR RFR: 8233228: Support named curves for all disabledAlgorithms

I believe I have address all the comments in the updated CSR. I have also added the "include" keyword for the new property along with the description for it's use. However, regarding the brainpool curves, the ones you say that we do not support are in CurveDB.java. It was my impression that

Re: [14] RFR: 8233228: Support named curves for all disabledAlgorithms

On 12/9/19 1:04 PM, Anthony Scarpino wrote: I've updated the webrev to address many of the comments.  In particular adding checks when keys given directly.  Also, the changing from legacyEC hardcoded list to a security property jdk.disabled.namedCurves. https://cr.openjdk.java.net/~ascarpino/8

Re: RFR [14] JDK-8235655, Clean the duplicated block in SSLContextImpl

Looks fine to me. regards, Sean. On 10/12/2019 14:35, Xuelei Fan wrote: On 12/10/2019 6:34 AM, Xuelei Fan wrote: Hi, Could I get the following code-cleanup patch reviewed?     cr.openjdk.java.net/~xuelei/8235655/webrev.00 missing the protocol part: http://cr.openjdk.java.net/~xuelei/

Re: RFR [14]JDK-8235311, Tag mismatch may alert bad_record_mac

Looks fine to me. --Sean On 12/10/19 9:01 AM, Xuelei Fan wrote: Hi, Could I get the following code reviewed?    http://cr.openjdk.java.net/~xuelei/8235311/webrev.00/ Basically, bad_record_mac alert should be used for AEADBadTagException. Simple fix, no new regression test.  The TLS fuzzing

Re: RFR [14] JDK-8235655, Clean the duplicated block in SSLContextImpl

On 12/10/2019 6:34 AM, Xuelei Fan wrote: Hi, Could I get the following code-cleanup patch reviewed?    cr.openjdk.java.net/~xuelei/8235655/webrev.00 missing the protocol part: http://cr.openjdk.java.net/~xuelei/8235655/webrev.00/ In the SSLContextImpl.java, duplicated arrays are used

RFR [14] JDK-8235655, Clean the duplicated block in SSLContextImpl

Hi, Could I get the following code-cleanup patch reviewed? cr.openjdk.java.net/~xuelei/8235655/webrev.00 In the SSLContextImpl.java, duplicated arrays are used in the same block, which could be simplified. Simple update, code cleanup, no new regression test. Thanks, Xuelei

Re: RFR[14] JDK-8231810: javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java fails intermittently with "java.lang.Exception: Unexpected EOF"

Looks fine to me. Thanks, Xuelei On 12/10/2019 12:29 AM, sha.ji...@oracle.com wrote: Hi, When the server socket in this test tries to receive close_notify, possibly the client socket is (being) closed. Without this patch, this failure was easily reproduced by running the test in a loop. Wi

RFR [14]JDK-8235311, Tag mismatch may alert bad_record_mac

Hi, Could I get the following code reviewed? http://cr.openjdk.java.net/~xuelei/8235311/webrev.00/ Basically, bad_record_mac alert should be used for AEADBadTagException. Simple fix, no new regression test. The TLS fuzzing test confirmed this patch. Thanks, Xuelei

Re: CSR RFR: 8233228: Support named curves for all disabledAlgorithms

In general, this CSR looks good. Here are my specific comments: - The Scope should be "JDK" since these are JDK supported security properties. - The Fix Version should also include 7-pool. - I would change the summary to "This change adds named elliptic curves to the jdk.[tls|certpath|jar].d

RFR 8234465: Encoded elliptic curve private keys should include the public point

Please review the code change at http://cr.openjdk.java.net/~weijun/8234465/webrev.00/ The fix is mostly inside ECPrivateKeyImpl. When an EC keypair is newly generated, a copy of the ECPoint of the public key is put inside the private key. This ECPoint can be stored in a PKCS #8 file. When r

RFR[14] JDK-8231810: javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java fails intermittently with "java.lang.Exception: Unexpected EOF"

Hi, When the server socket in this test tries to receive close_notify, possibly the client socket is (being) closed. Without this patch, this failure was easily reproduced by running the test in a loop. With this patch, I didn't reproduce it in the same way. Issue: https://bugs.openjdk.java.