Re: [15] RFR 8238898: Missing hash characters for header on license file

Change looks fine. I can see it matches the style of another file in the same directory. Thanks, Max > On Feb 12, 2020, at 8:47 AM, Valerie Peng wrote: > > Anyone can help with a quick review? This fix is for address typos in license > header file. No behavior/impl changes. > > Bug: https://

[15] RFR 8238898: Missing hash characters for header on license file

Anyone can help with a quick review? This fix is for address typos in license header file. No behavior/impl changes. Bug: https://bugs.openjdk.java.net/browse/JDK-8238898 Webrev: http://cr.openjdk.java.net/~valeriep/8238898/webrev.00/ Thanks, Valerie

Re: RFR 8163251 : Hard coded loop limit prevents reading of smart card data greater than 8k

Thank you Roger! We do have a manual test that performs some sanity verification that a transmit call works [1]. I have also received a confirmation from a submitter of the bug that the patched JDK now allows to retrieve data larger than 32k, which was not possible before the fix. I'll add

Re: RFR 8163251 : Hard coded loop limit prevents reading of smart card data greater than 8k

Hi Valerie! To be honest, the all these limitations are not quite clear to me. If the command is using an extended Le word to specify the expected length of the response data, then this length can be at most 65536. If a short Le was used, then the length can be at most 256. However, if we re

Re: RFR[8u252] - MR3 - ALPN & RSASSA-PSS in Java SE 8

Missed security-dev. On 2/4/2020 5:08 PM, Xuelei Fan wrote: > 1.  ALPN: >   http://cr.openjdk.java.net/~wetmore/MR3-codereview-8u252/ALPN I reviewed this part, which look good to me. Thanks, Xuelei On 2/4/2020 3:24 PM, Bradford Wetmore wrote: I added a simple PSS 32-bit windows crash fix

Fwd: Re: RFR[8u252] - MR3 - ALPN & RSASSA-PSS in Java SE 8

Forwarding to security-dev, was only posted to jdk8u-dev. Brad Forwarded Message Subject: Re: RFR[8u252] - MR3 - ALPN & RSASSA-PSS in Java SE 8 Date: Tue, 4 Feb 2020 17:08:59 -0800 From: Xuelei Fan Organization: Oracle Corporation To: [email protected] 1. ALPN:

Fwd: Re: RFR[8u252] - MR3 - ALPN & RSASSA-PSS in Java SE 8

Forwarding to security-dev, was only posted to jdk8u-dev. Brad Forwarded Message Subject: Re: RFR[8u252] - MR3 - ALPN & RSASSA-PSS in Java SE 8 Date: Wed, 5 Feb 2020 14:31:14 -0800 From: Valerie Peng Organization: Oracle Corporation To: [email protected], Bradford Wet

Re: RFR 8163251 : Hard coded loop limit prevents reading of smart card data greater than 8k

To test this you’d have to have an applet and card and card reader or an applet and simulator.It’s possible you could build something using the java card simulator in the JCDK, but I don’t know if that would actually exercise the code. Mike Sent from my iPad > On Feb 11, 2020, at 09:47

Re: RFR 8163251 : Hard coded loop limit prevents reading of smart card data greater than 8k

Hi Ivan, Raising it to work up to the spec'd limit is a good approach. Do we have a way to test this?  Aka: There should be a test. Roger On 2/10/20 8:07 PM, Ivan Gerasimov wrote: Thank you Michael! It's a good point about maximum length. Here's the updated webrev with the new System prope

RFR 8237218: Support NIST Curves verification in java implementation

Please take a review at http://cr.openjdk.java.net/~weijun/8237218/webrev.02/ A test is added that uses a patched ECDSASignature.java that exposes how the signature is verified. BTW, I also updated ECDSASignature.java a little to accept non SunEC keys, so that I can do some interop testing.