Re: RFR: 8240686: 70 security tests are failing on Windows due to "Fetch artifact failed"

Quick fix. Thanks for the update, which looks good to me. Xuelei On 3/6/2020 8:00 PM, Rajan Halade wrote: The fetch artifact issue is fixed within infra so these tests can be removed from ProblemList now. Please review this changeset: diff -r 7af6364e1792 test/jdk/ProblemList.txt --- a/test/

RFR: 8240686: 70 security tests are failing on Windows due to "Fetch artifact failed"

The fetch artifact issue is fixed within infra so these tests can be removed from ProblemList now. Please review this changeset: diff -r 7af6364e1792 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt Fri Mar 06 18:03:09 2020 -0800 +++ b/test/jdk/ProblemList.txt Fri Mar 06 19:56:26 2020 -0

Re: 8237219: Disabling the native SunEC implementation

Webrev is updated and the CSR is updated with a comment if the property is false. https://cr.openjdk.java.net/~ascarpino/8237219/webrev.02 thanks Tony On 3/2/20 4:40 PM, Anthony Scarpino wrote: Hi I need a review of the CSR and webrev for disabling by default the native SunEC curves from t

Re: [RFR] 8166597: Crypto support for the EdDSA Signature Algorithm (JEP 339)

On 3/6/20 10:22 AM, Sean Mullan wrote: It will take me a few iterations to review all of this, but here are some comments so far, mostly minor things: - src/java.base/share/classes/java/security/spec/NamedParameterSpec.java Need "@since 15" on the two new constants. (Assuming this goes in 15).

Re: [RFR] 8166597: Crypto support for the EdDSA Signature Algorithm (JEP 339)

It will take me a few iterations to review all of this, but here are some comments so far, mostly minor things: - src/java.base/share/classes/java/security/spec/NamedParameterSpec.java Need "@since 15" on the two new constants. (Assuming this goes in 15). - src/java.base/share/classes/sun/secu

Re: RFR [15]: 8240684: ProblemList 70 security tests that are failing on Windows due to "Fetch artifact failed"

Thumbs up! Thanks for handling this. Dan On 3/6/20 12:31 PM, Sean Mullan wrote: Please review this change to ProblemList 70 security tests while we diagnose the artifactory issues. See https://bugs.openjdk.java.net/browse/JDK-8240684 for more info. diff -r 1c40993361d0 test/jdk/ProblemList

Re: RFR [15]: 8240684: ProblemList 70 security tests that are failing on Windows due to "Fetch artifact failed"

Looks fine to me. Xuelei > On Mar 6, 2020, at 9:31 AM, Sean Mullan wrote: > > Please review this change to ProblemList 70 security tests while we diagnose > the artifactory issues. > > See https://bugs.openjdk.java.net/browse/JDK-8240684 for more info. > > diff -r 1c40993361d0 test/jdk/Prob

RFR [15]: 8240684: ProblemList 70 security tests that are failing on Windows due to "Fetch artifact failed"

Please review this change to ProblemList 70 security tests while we diagnose the artifactory issues. See https://bugs.openjdk.java.net/browse/JDK-8240684 for more info. diff -r 1c40993361d0 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt Mon Feb 24 19:03:34 2020 +0100 +++ b/test/jdk/Pr