Re: RFR [15] JDK-8215711, Missing key_share extension for (EC)DHE key exchange should alert missing_extension

2020-04-05 Thread Xuelei Fan
On 4/5/2020 1:41 PM, Anthony Scarpino wrote: On 4/4/20 6:11 PM, Xuelei Fan wrote: Hi, Could I have the following update reviewed? http://cr.openjdk.java.net/~xuelei/8215711/webrev.00/ In the current TLS implementation, if one of "supported_groups" extension and "key_share" extension is

Re: RFR [15] JDK-8215711, Missing key_share extension for (EC)DHE key exchange should alert missing_extension

2020-04-05 Thread Anthony Scarpino
On 4/4/20 6:11 PM, Xuelei Fan wrote: Hi, Could I have the following update reviewed?     http://cr.openjdk.java.net/~xuelei/8215711/webrev.00/ In the current TLS implementation, if one of "supported_groups" extension and "key_share" extension is not present in the ClientHello handshake mess

Re: RFR[15]: 8172404: Tools should warn if weak algorithms are used before restricting them

2020-04-05 Thread Hai-May Chao
Here is the webrev: http://cr.openjdk.java.net/~weijun/8172404/webrev.00/ Thanks, Hai-May > On Apr 4, 2020, at 11:41 PM, Hai-May Chao wrote: > > Hi, > > I'd like to request a review for: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8172404 >

Re: [RFR] 8166597: Crypto support for the EdDSA Signature Algorithm (JEP 339)

2020-04-05 Thread Weijun Wang
OK, I undertand now: 1. Crypto primitives (Signature/KeyFactory/KeyPairGenerator) would support all "EdDSA" and "Ed25519"/"Ed448", and their getAlgorithm() returns what was used back in getInstance(). 2. Key's getAlgorithm() always returns "EdDSA". Thanks, Max > On Apr 4, 2020, at 6:02 AM, An