Re: RFR 8242260: Remove customizable ContentSigner from jarsigner

2020-04-09 Thread Wang Weijun
So the classes will be useless but at least old program still compiles. I'll modify the CSR and see how Joe thinks of this. Thanks, Max > 在 2020年4月9日,22:58,Sean Mullan 写道: > > On 4/9/20 10:52 AM, Weijun Wang wrote: >> All info for signing are passed into a ContentSigner through a >>

Re: RFR JDK-8239595/JDK-8239594 : ssl context version is not respected/jdk.tls.client.protocols is not respected

2020-04-09 Thread Daniel Fuchs
Thanks Rahul. I believe you can mark it as Delivered now. On 09/04/2020 14:13, Rahul wrote: Thanks for the review Daniel. I have created a release note. RN :https://bugs.openjdk.java.net/browse/JDK-8242387

Re: RFR 8242260: Remove customizable ContentSigner from jarsigner

2020-04-09 Thread Sean Mullan
On 4/9/20 10:52 AM, Weijun Wang wrote: All info for signing are passed into a ContentSigner through a ContentSignerParameters object. In order to pass more info, I’ll need to create new interface methods for it. But you can just use your solution in JarSigner in the webrev below where you

Re: RFR 8242260: Remove customizable ContentSigner from jarsigner

2020-04-09 Thread Weijun Wang
All info for signing are passed into a ContentSigner through a ContentSignerParameters object. In order to pass more info, I’ll need to create new interface methods for it. —Max > 在 2020年4月9日,21:27,Sean Mullan 写道: > > On 4/9/20 3:13 AM, Wang Weijun wrote: >> Oh, I'll then need to add new

Re: RFR 8242260: Remove customizable ContentSigner from jarsigner

2020-04-09 Thread Sean Mullan
On 4/9/20 3:13 AM, Wang Weijun wrote: Oh, I'll then need to add new fields to it to support RSASSA-PSS and EdDSA. Sigh. Why would you need to do that if they are deprecated? --Sean --Max 在 2020年4月9日,01:58,Sean Mullan 写道: We never actually deprecated the com.sun.jarsigner package with

Re: RFR JDK-8239595/JDK-8239594 : ssl context version is not respected/jdk.tls.client.protocols is not respected

2020-04-09 Thread Rahul
Thanks for the review Daniel. I have created a release note. RN : https://bugs.openjdk.java.net/browse/JDK-8242387 --Rahul On 08/04/2020, 16:00, "Daniel Fuchs" wrote: Good work Rahul! I am not sure whether that deserves a CSR (probably not) but we may want to create

Re: RFR 8242184: CRL generation error with RSASSA-PSS

2020-04-09 Thread Wang Weijun
Valerie in another reply suggested that the default parameters of the default sigAlg depends on either the size of the key (if RSA) of the params of the key (if RSASSA-PSS). I'll address all of these in another bug. Thanks, Max > 在 2020年4月9日,03:47,Sean Mullan 写道: > > On 4/6/20 11:11 PM,

Re: RFR 8242260: Remove customizable ContentSigner from jarsigner

2020-04-09 Thread Wang Weijun
Oh, I'll then need to add new fields to it to support RSASSA-PSS and EdDSA. Sigh. --Max > 在 2020年4月9日,01:58,Sean Mullan 写道: > > We never actually deprecated the com.sun.jarsigner package with a > forRemoval=true flag, so while it may be very low-risk to remove these APIs, > I feel that we