Re: [RFR] 8242008: SSLSession inconsistencies

2020-04-14 Thread Xuelei Fan
It looks good to me. Nice to see a a new template! Thanks, Xuelei On 4/8/2020 1:18 PM, Anthony Scarpino wrote: Hi, I'd like a review of the following change.  There wre inconsistencies with SSLSession and session caching that needed to be fixed.  They are: - With stateless resumption, SSLSes

Re: [RFR] 8242008: SSLSession inconsistencies

2020-04-14 Thread Jamil Nimeh
Hi Tony, this looks good to me. --Jamil On 4/8/2020 1:18 PM, Anthony Scarpino wrote: Hi, I'd like a review of the following change.  There wre inconsistencies with SSLSession and session caching that needed to be fixed.  They are: - With stateless resumption, SSLSession.getSessionContext() wo

Re: RFR [15] JDK-8242145, New System Properties to configure the TLS signature schemes

2020-04-14 Thread Jamil Nimeh
Looks pretty good, a couple questions/comments: * SSLConfiguration.java o Line 471-473: Does the call to SignatureScheme.nameOf(String) ever throw IAE?  I don't see anything in the for-each loop in that method that would. * CustomizedClientSchemes and CustomizedServerSchemes

Re: RFR [15] JDK-8242145, New System Properties to configure the TLS signature schemes

2020-04-14 Thread Xuelei Fan
ping ... On 4/3/2020 4:13 PM, Xuelei Fan wrote: Hi, Could I get the following update reviewed? Webrev: http://cr.openjdk.java.net/~xuelei/8242145/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8242141 CSR: https://bugs.openjdk.java.net/browse/JDK-8242145 Release-note: https://bugs.o

RFR Release Note for JDK-8172680 "Support SHA-3 based Hmac algorithms"

2020-04-14 Thread Valerie Peng
The changes have been integrated. This is a sub-task for the release-note update. Could someone help review the release note wording? It's at https://bugs.openjdk.java.net/browse/JDK-8241326 Thanks, Valerie

sun.security.spnego.msinterop does not work anymore/disable by default for 15

2020-04-14 Thread Osipov, Michael
Hi Max, I have just wasted an entire day to make the following observation: Running Java 8u242, SPNEGO acceptor via HTTP. SSPI clients constantly report: SEC_E_INVALID_TOKEN. Tried with Java via JNA, Java via new SSPI Bridge, Python SSPI Negotiate module. Regardless of what I do the token gen

Re: [15] RFR JDK-8242556 "Cannot load RSASSA-PSS public key with non-null params from byte array"

2020-04-14 Thread Sean Mullan
Looks fine to me. --Sean On 4/14/20 2:33 PM, Valerie Peng wrote: Can someone help reviewing this trivial fix? The fix is to change AlgorithmId.java to use the algorithm name over the object identifier string when looking up impls for DER encoding parsing. Bug: https://bugs.openjdk.java.net

[15] RFR JDK-8242556 "Cannot load RSASSA-PSS public key with non-null params from byte array"

2020-04-14 Thread Valerie Peng
Can someone help reviewing this trivial fix? The fix is to change AlgorithmId.java to use the algorithm name over the object identifier string when looking up impls for DER encoding parsing. Bug: https://bugs.openjdk.java.net/browse/JDK-8242556 Webrev: http://cr.openjdk.java.net/~valeriep/8

Re: RFR 8242260: Remove customizable ContentSigner from jarsigner

2020-04-14 Thread Weijun Wang
mach5 passed. > On Apr 14, 2020, at 3:27 PM, Weijun Wang wrote: > > After some discussion, we decide to keep the classes in JDK 15 but add a > `forRemoval=true` argument. Related jarsigner help screen and warning message > are also updated. > > Please review everything updated at: > > Relea

Re: RFR 8242260: Remove customizable ContentSigner from jarsigner

2020-04-14 Thread Weijun Wang
After some discussion, we decide to keep the classes in JDK 15 but add a `forRemoval=true` argument. Related jarsigner help screen and warning message are also updated. Please review everything updated at: Release note : https://bugs.openjdk.java.net/browse/JDK-8242261 CSR : https: