Re: RFR 8242811: AlgorithmId::getDefaultAlgorithmParameterSpec returns incompatible PSSParameterSpec for an RSASSA-PSS key

2020-04-17 Thread Hai-May Chao
Changes good to me. Hai-May > On Apr 17, 2020, at 3:27 PM, Valerie Peng wrote: > > > Changes look good~ > > Valerie > > On 4/15/2020 3:34 AM, Weijun Wang wrote: >> Please take a review at >> >>https://cr.openjdk.java.net/~weijun/8242811/webrev.00/ >> >> The

Re: RFR 8242811: AlgorithmId::getDefaultAlgorithmParameterSpec returns incompatible PSSParameterSpec for an RSASSA-PSS key

2020-04-17 Thread Valerie Peng
Changes look good~ Valerie On 4/15/2020 3:34 AM, Weijun Wang wrote: Please take a review at https://cr.openjdk.java.net/~weijun/8242811/webrev.00/ The AlgorithmId::getDefaultAlgorithmParameterSpec method is used internally to retrieve a default AlgorithmParameterSpec to initialize a

Re: RFR 8242184: CRL generation error with RSASSA-PSS

2020-04-17 Thread Sean Mullan
On 4/15/20 8:28 AM, Weijun Wang wrote: On Apr 9, 2020, at 3:46 AM, Sean Mullan wrote: On 4/6/20 11:11 PM, Weijun Wang wrote: Please review the fix at http://cr.openjdk.java.net/~weijun/8242184/webrev.00/ The major change is inside X509CRLImpl.java to allow params setting and reading. I