If you look at the original SunJCE impl, it also did not register oid
for RC4 cipher. So, that's why I didn't include RC4 oid in
SecurityProviderConstants in the aliases for RC4.
If I recall correctly, "RC4" is the algorithm name, however, due to some
patent(?) concern, non-RSA vendors regi
Hi Max,
I believe most of your comments (except the two below) in this email
should already be addressed in webrev.01.
I caught them by looking at the "skipped" debug output. Can we add some logic
to detect this? For example, for those nonpreferred OIDs, use a special constructor?
Hmm, ok,
toString() returns the standard name which the enum corresponds to.
Yes, I agree that it's better to use a dedicated method name for this.
Will address this in webrev.02.
Valerie
On 4/28/2020 3:37 AM, Weijun Wang wrote:
Is OidString::toString really used anywhere? If so, I suggest we crea
Hi Max,
Here is the updated webrev
http://cr.openjdk.java.net/~valeriep/8242151/webrev.01/
which should address your earlier comments (see below)
- OidString renamed to KnownOIDs and updated the aliasing handling code
in both KnownOIDs and SecurityProviderConstants classes
- Removed additi
On 4/29/2020 1:08 AM, Weijun Wang wrote:
> Please take a review at
>
>https://cr.openjdk.java.net/~weijun/8244087/webrev.00
>
> I modified the test a little and thus updated the test program with a new
> copyright year and a @bug. This makes sure the automatic (?) verifier knows
> there is
Please take a review at
https://cr.openjdk.java.net/~weijun/8244087/webrev.00
I modified the test a little and thus updated the test program with a new
copyright year and a @bug. This makes sure the automatic (?) verifier knows
there is a regression test.
*Frances*: Do I need to link this R
