RFR 8244974: Test sun/security/krb5/auto/ReplayCachePrecise.java failes to throw KrbException

Please take a review at https://cr.openjdk.java.net/~weijun/8244974/webrev.00 Time could change during the test and the cache thought it's a new entry. Thanks, Max

Re: [15] RFR: 8209632: Develop new tests for EdDSA API

It’s a typo issue. I can add missing character “d” before pushing the change. Thanks, Siba > On 14-May-2020, at 9:00 AM, Anthony Scarpino > wrote: > > On 5/13/20 2:55 AM, [email protected] wrote: >> Hi Tony, >> Please review the patch of new Tests developed for EdDSA, >> JBS: https:

Re: [15] RFR: 8209632: Develop new tests for EdDSA API

On 5/13/20 2:55 AM, [email protected] wrote: Hi Tony, Please review the patch of new Tests developed for EdDSA, JBS: https://bugs.openjdk.java.net/browse/JDK-8209632 Webrev: http://cr.openjdk.java.net/~ssahoo/8209632/webrev.00/ Thanks, Siba Looking through the tests, I didn't see

Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

> On May 14, 2020, at 3:17 AM, Valerie Peng wrote: > > Hi Max, > > Thanks for review~ > > Webrev is updated accordingly for your comments: > http://cr.openjdk.java.net/~valeriep/8242151/webrev.04/ > > Please find replies inline below: > > On 5/11/2020 9:24 PM, Weijun Wang wrote: >> Some f

Re: RFR 8244565: Accept PKCS #8 with version number 1

I will take a look. Valerie On 5/8/2020 3:39 AM, Weijun Wang wrote: Found an existing test I can update. Webrev updated at http://cr.openjdk.java.net/~weijun/8244565/webrev.01/ Thanks, Max On May 8, 2020, at 5:41 PM, Weijun Wang wrote: Please take a review at http://cr.openjdk.jav

Re: RFR JDK-8206925,,Support the certificate_authorities extension

On 5/13/2020 2:11 PM, Sean Mullan wrote: It is not expected to use this extension regularly. Please let me know if you still prefer to use "enableCAExtension". Also, it is a bit unfortunate that we have to have a system property to enable it. Can we not enable it based on whether the config

Re: RFR JDK-8206925,,Support the certificate_authorities extension

On 5/13/20 4:16 PM, Xuelei Fan wrote: Updated webrev: http://cr.openjdk.java.net/~xuelei/8206925/webrev.02/ The CSR and release note were updated accordingly, to use the new system property. On 5/13/2020 6:38 AM, Sean Mullan wrote: On 5/12/20 5:43 PM, Xuelei Fan wrote: Updated webrev: http:

Re: RFR JDK-8240871: SSLEngine handshake status immediately after the handshake can be NOT_HANDSHAKING rather than FINISHED with TLSv1.3

On 5/13/2020 9:41 AM, Anthony Scarpino wrote: On 4/30/20 10:19 AM, Xuelei Fan wrote: Hi, Could I get the following update reviewed: http://cr.openjdk.java.net/~xuelei/8240871/webrev.00/ For TLS 1.3 full handshake, if the last handshake flight wraps the Finished together with other handsh

Re: RFR JDK-8206925,,Support the certificate_authorities extension

Hi Alexey, It a good information for interop. Thank you! I will see how to workaround it. Thanks, Xuelei On 5/13/2020 3:00 AM, Alexey Bakhtin wrote: Hello Xuelei, I’m not a reviewer but I have some comment which could be helpful for your implementation. We’ve developed CA Extension in th

Re: RFR JDK-8206925,,Support the certificate_authorities extension

Updated webrev: http://cr.openjdk.java.net/~xuelei/8206925/webrev.02/ The CSR and release note were updated accordingly, to use the new system property. On 5/13/2020 6:38 AM, Sean Mullan wrote: On 5/12/20 5:43 PM, Xuelei Fan wrote: Updated webrev: http://cr.openjdk.java.net/~xuelei/8206925/w

Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

Hi Max, Thanks for review~ Webrev is updated accordingly for your comments: http://cr.openjdk.java.net/~valeriep/8242151/webrev.04/ Please find replies inline below: On 5/11/2020 9:24 PM, Weijun Wang wrote: Some files have trailing spaces. Yes, I generally check for white spaces before inte

Re: RFR JDK-8240871: SSLEngine handshake status immediately after the handshake can be NOT_HANDSHAKING rather than FINISHED with TLSv1.3

On 4/30/20 10:19 AM, Xuelei Fan wrote: Hi, Could I get the following update reviewed:     http://cr.openjdk.java.net/~xuelei/8240871/webrev.00/ For TLS 1.3 full handshake, if the last handshake flight wraps the Finished together with other handshake message, for example client certificate, t

Re: RFR JDK-8206925,,Support the certificate_authorities extension

On 5/12/20 5:43 PM, Xuelei Fan wrote: Updated webrev: http://cr.openjdk.java.net/~xuelei/8206925/webrev.01/ On 5/12/2020 12:40 PM, Sean Mullan wrote: On 5/5/20 2:29 PM, Xuelei Fan wrote: Hi, Could I get the following update reviewed? RFE: https://bugs.openjdk.java.net/browse/JDK-8206925 CSR:

Re: RFR JDK-8206925,,Support the certificate_authorities extension

Hello Xuelei, I’m not a reviewer but I have some comment which could be helpful for your implementation. We’ve developed CA Extension in the OpenJSSE provider [1] and found an issue with a third party server implementations. According to RFC-8446 specification [2] the maximum size of the CA exte

[15] RFR: 8209632: Develop new tests for EdDSA API

Hi Tony, Please review the patch of new Tests developed for EdDSA, JBS: https://bugs.openjdk.java.net/browse/JDK-8209632 Webrev: http://cr.openjdk.java.net/~ssahoo/8209632/webrev.00/ Than