Good. It's at https://hg.openjdk.java.net/jdk/jdk/rev/6309cf0a3b17 now.
> On May 23, 2020, at 2:44 PM, Hai-May Chao wrote:
>
> I did testing with a MD5RSA root CA. Updated the webrev.
>
> Thanks,
> Hai-May
>
>
>> On May 22, 2020, at 8:50 PM, Weijun Wang wrote:
>>
>> You probably should use
I did testing with a MD5RSA root CA. Updated the webrev.
Thanks,
Hai-May
> On May 22, 2020, at 8:50 PM, Weijun Wang wrote:
>
> You probably should use shouldNotMatch() because here it's a pattern match
> instead of simply contain.
>
> Try add a MD5withRSA cert there to see how it works.
>
>
You probably should use shouldNotMatch() because here it's a pattern match
instead of simply contain.
Try add a MD5withRSA cert there to see how it works.
Thanks,
Max
> On May 23, 2020, at 11:01 AM, Hai-May Chao wrote:
>
> Hi,
>
> I’d like to request q review for -
>
> JBS: https://bugs.ope
Hi,
I’d like to request q review for -
JBS: https://bugs.openjdk.java.net/browse/JDK-8245665
Webrev: https://cr.openjdk.java.net/~hchao/8245665/webrev.00/
Keytool only emits warnings for the root CA in cacerts using the weak key, but
not for using the weak algorithm. So test case WeakAlg.java s
>>
>> In the Supported Algorithms, what does keysize: (empty) mean? Do you mean
>> "any size" as in the current table for DSA?
>
> You can say that (RSASSA-PSS can be any size, EdDSA can be any of those 2
> sizes). Of course, it's not unrelated, and I've added "using the same
> parameters of t
> On May 23, 2020, at 4:44 AM, Sean Mullan wrote:
>
> On 5/22/20 10:30 AM, Weijun Wang wrote:
>> Please take a review at
>> CSR : https://bugs.openjdk.java.net/browse/JDK-8245274
>>webrev : http://cr.openjdk.java.net/~weijun/8242068/webrev.00/
>> Major points in CSR:
>> - new sigalg
On 5/22/2020 11:17 AM, Sean Mullan wrote:
On 5/22/20 1:55 PM, Xuelei Fan wrote:
* test/jdk/sun/security/ssl/X509TrustManagerImpl/TooMuchCAs.java
Will this test FAIL if we ever exceed the maximum number of CAs? I
think it is important that it does FAIL, as the extension is
effectively not work
On 5/22/20 10:30 AM, Weijun Wang wrote:
Please take a review at
CSR : https://bugs.openjdk.java.net/browse/JDK-8245274
webrev : http://cr.openjdk.java.net/~weijun/8242068/webrev.00/
Major points in CSR:
- new sigalg "RSASSA-PSS", "EdDSA", "Ed25519" and "Ed448" can be used in
jarsig
On 5/22/20 1:55 PM, Xuelei Fan wrote:
* test/jdk/sun/security/ssl/X509TrustManagerImpl/TooMuchCAs.java
Will this test FAIL if we ever exceed the maximum number of CAs? I
think it is important that it does FAIL, as the extension is
effectively not working anymore and could cause compatibility i
All good comments. I updated the code and CSR accordingly.
http://cr.openjdk.java.net/~xuelei/8206925/webrev.05/
On 5/22/2020 8:41 AM, Sean Mullan wrote:
On 5/15/20 6:11 PM, Xuelei Fan wrote:
New webrev: http://cr.openjdk.java.net/~xuelei/8206925/webrev.04/
*
src/java.base/share/classes/
On 5/15/20 6:11 PM, Xuelei Fan wrote:
New webrev: http://cr.openjdk.java.net/~xuelei/8206925/webrev.04/
*
src/java.base/share/classes/sun/security/ssl/CertificateAuthoritiesExtension.java
212 SSLLogger.warning(
213 "Too much certificate autho
Please take a review at
CSR : https://bugs.openjdk.java.net/browse/JDK-8245274
webrev : http://cr.openjdk.java.net/~weijun/8242068/webrev.00/
Major points in CSR:
- new sigalg "RSASSA-PSS", "EdDSA", "Ed25519" and "Ed448" can be used in
jarsigner
- The ".RSA" and ".EC" block extension
Cross-posting to hotspot-dev for additional review since the code
changes are in hotspot.
--Sean
On 5/21/20 1:24 PM, Simon Tooke wrote:
Hello,
I'd like to request a review for:
JBS: https://bugs.openjdk.java.net/browse/JDK-8243114
Webrev: http://cr.openjdk.java.net/~stooke/webrevs/jdk-82431
13 matches
Mail list logo
