Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Am 2020-05-21 um 09:35 schrieb Alexey Bakhtin: Hello, Could you please review the following patch: JBS: https://bugs.openjdk.java.net/browse/JDK-8245527 Webrev: http://cr.openjdk.java.net/~abakhtin/8245527/webrev.v0/ Let's go through your changes statically: * The JIRA issue title has a

Re: RFR 8242068: Signed JAR support for RSASSA-PSS and EdDSA

CSR updated at https://bugs.openjdk.java.net/browse/JDK-8245274 with the full patch on docs. Thanks, Max > On May 23, 2020, at 9:45 AM, Weijun Wang wrote: > >>> >>> In the Supported Algorithms, what does keysize: (empty) mean? Do you mean >>> "any size" as in the current table for DSA? >>

Re: RFR[15] 8245665: Test WeakAlg.java should only make sure no warning for weak signature algorithms by keytool on root CA

Good. It's at https://hg.openjdk.java.net/jdk/jdk/rev/6309cf0a3b17 now. > On May 23, 2020, at 2:44 PM, Hai-May Chao wrote: > > I did testing with a MD5RSA root CA. Updated the webrev. > > Thanks, > Hai-May > > >> On May 22, 2020, at 8:50 PM, Weijun Wang wrote: >> >> You probably should use

Re: RFR[15] 8245665: Test WeakAlg.java should only make sure no warning for weak signature algorithms by keytool on root CA

I did testing with a MD5RSA root CA. Updated the webrev. Thanks, Hai-May > On May 22, 2020, at 8:50 PM, Weijun Wang wrote: > > You probably should use shouldNotMatch() because here it's a pattern match > instead of simply contain. > > Try add a MD5withRSA cert there to see how it works. >