Re: [15] RFR JDK-8242897 KeyFactory.generatePublic( x509Spec ) failed with java.security.InvalidKeyException

2020-05-29 Thread Valerie Peng
Re-worked the fix a bit to take in Max's feedback: Webrev updated athttp://cr.openjdk.java.net/~valeriep/8242897/webrev.01/ Instead of completely reverting to the pre-PSS behavior of ignoring the OID in the DER encoding, this updated webrev has special handling to work with the scenario in the

Re: RFR 8242068: Signed JAR support for RSASSA-PSS and EdDSA

2020-05-29 Thread Sean Mullan
On 5/23/20 4:21 AM, Weijun Wang wrote: CSR updated at https://bugs.openjdk.java.net/browse/JDK-8245274 with the full patch on docs. Good to remove all of the DSA references :) I had a few comments, mostly wording suggestions: - In the Problem section, you should add references to the RFCs.

Re: RFR JDK-8240871: SSLEngine handshake status immediately after the handshake can be NOT_HANDSHAKING rather than FINISHED with TLSv1.3

2020-05-29 Thread Anthony Scarpino
Ok thanks.. no further questions. Tony On 5/29/20 9:54 AM, Xuelei Fan wrote: On 5/29/2020 8:59 AM, Anthony Scarpino wrote: Thanks for the changes Xuelei, it is much clearer to me now.  Two minor things and a question. NewSessionTicket:323.  The comment talks about an empty session ticket,

Re: RFR JDK-8240871: SSLEngine handshake status immediately after the handshake can be NOT_HANDSHAKING rather than FINISHED with TLSv1.3

2020-05-29 Thread Xuelei Fan
On 5/29/2020 8:59 AM, Anthony Scarpino wrote: Thanks for the changes Xuelei, it is much clearer to me now.  Two minor things and a question. NewSessionTicket:323.  The comment talks about an empty session ticket, SSLEngineImpl:167.  Comment uses old variable name Oops, I still missed the tw

Re: RFR JDK-8240871: SSLEngine handshake status immediately after the handshake can be NOT_HANDSHAKING rather than FINISHED with TLSv1.3

2020-05-29 Thread Anthony Scarpino
Thanks for the changes Xuelei, it is much clearer to me now. Two minor things and a question. NewSessionTicket:323. The comment talks about an empty session ticket, SSLEngineImpl:167. Comment uses old variable name One question, NewSessionTicket 464-470 and SSLEngineImpl.writeRecord() 167