Re: RFR 8242068: Signed JAR support for RSASSA-PSS and EdDSA

2020-06-01 Thread Sean Mullan
On 5/31/20 9:26 PM, Weijun Wang wrote: Replies inline below. I've removed the items I agree with for simplicity. On May 30, 2020, at 3:32 AM, Sean Mullan wrote: On 5/23/20 4:21 AM, Weijun Wang wrote: CSR updated at https://bugs.openjdk.java.net/browse/JDK-8245274 with the full patch on

RFR 8244148: keytool -printcert and -printcrl should support the -trustcacerts and -keystore options

2020-06-01 Thread Hai-May Chao
Hi, I’d like to request a review for: JBS: https://bugs.openjdk.java.net/browse/JDK-8244148 CSR: https://bugs.openjdk.java.net/browse/JDK-8246269 Webrev: http://cr.openjdk.java.net/~hchao/8244148/webrev.00/ The change is to add the support of -trustcacerts and -keystore options to -printcert

Re: Alias internal format leaked to application code?

2020-06-01 Thread Simone Bordet
Hi, On Mon, Jun 1, 2020 at 5:24 PM Xuelei Fan wrote: > > Good catch, Simone. It is not expected to parser the alias in application > code. Would you like file a bug? https://bugs.openjdk.java.net/browse/JDK-8246262. Thanks! -- Simone Bordet --- Finally, no matter how good the architecture

Re: Alias internal format leaked to application code?

2020-06-01 Thread Xuelei Fan
Good catch, Simone. It is not expected to parser the alias in application code. Would you like file a bug? Thanks, Xuelei > On Jun 1, 2020, at 2:13 AM, Simone Bordet wrote: > > Hi, > > when using "PKIX" as KeyManagerFactoryAlgorithm, the alias is > manipulated from what's in the keystore

Alias internal format leaked to application code?

2020-06-01 Thread Simone Bordet
Hi, when using "PKIX" as KeyManagerFactoryAlgorithm, the alias is manipulated from what's in the keystore (for example, "jetty") to an internal format such as "N.0.jetty", where N is an increasing number (in sun.security.ssl.X509KeyManagerImpl.makeAlias()). The problem is that (especially in

Re: RFR 8244565: Accept PKCS #8 with version number 1

2020-06-01 Thread Weijun Wang
Updated webrev at https://cr.openjdk.java.net/~weijun/8244565/webrev.03. I've inlined more methods that is only called once and inside the same method. Thanks, Max > On May 28, 2020, at 9:16 AM, Weijun Wang wrote: > > > >> On May 28, 2020, at 8:46 AM, Valerie Peng wrote: >> >> Hi