Re: RFR [16] [JDK-8248745] Add jarsigner and keytool tests for restricted algorithms

2020-08-04 Thread Hai-May Chao
Hi Muneer, Updated webrev looks good. Thanks, Hai-May > On Aug 4, 2020, at 7:26 PM, abdul.kolarku...@oracle.com wrote: > > Thanks Hai-May for review. > > Updated the webrev with your comment > -http://cr.openjdk.java.net/~akolarkunnu/8248745/webrev.01/ > > -Muneer > > On 04/08/20 11:58

Re: RFR [16] [JDK-8248745] Add jarsigner and keytool tests for restricted algorithms

2020-08-04 Thread abdul . kolarkunnu
Thanks Hai-May for review. Updated the webrev with your comment -http://cr.openjdk.java.net/~akolarkunnu/8248745/webrev.01/ -Muneer On 04/08/20 11:58 pm, Hai-May Chao wrote: Hi Muneer, Looks good with one minor comment. #58: suggest that the SECURITY_WARNING will also include “and is

RFR 8251117: Cannot check P11Key size in P11Cipher and P11AEADCipher

2020-08-04 Thread Martin Balao
Hi, I'd like to propose a fix for 8251117 [1], on behalf of Zdenek Zambersky (Red Hat employee - OCA signed). Webrev.00: * http://cr.openjdk.java.net/~mbalao/webrevs/8251117/8251117.webrev.00/ As noted in the ticket [1], the fix is about using P11Key::length method for retrieving P11Key sizes

Re: RFR [16] [JDK-8248745] Add jarsigner and keytool tests for restricted algorithms

2020-08-04 Thread Hai-May Chao
Hi Muneer, Looks good with one minor comment. #58: suggest that the SECURITY_WARNING will also include “and is disabled” at the end to make it clear. Thanks, Hai-May > On Jul 27, 2020, at 9:15 AM, abdul.kolarku...@oracle.com wrote: > > Hi All, > > This is a new test int the area of