Re: RFR: 8153005: Upgrade the default PKCS12 encryption/MAC algorithms

2020-10-06 Thread Weijun Wang
On Tue, 6 Oct 2020 18:34:34 GMT, Sean Mullan wrote: >> I only know Windows Server 2019 can accept the new algorithms. > > Ok, but maybe we can split this test in two and use the jtreg @requires tag > to run the newer algorithms on Windows > Server 2019? It would be a useful test if this is the

Re: RFR: 8153005: Upgrade the default PKCS12 encryption/MAC algorithms

2020-10-06 Thread Sean Mullan
On Fri, 2 Oct 2020 19:07:20 GMT, Weijun Wang wrote: >> test/jdk/sun/security/mscapi/VeryLongAlias.java line 51: >> >>> 49: public static void main(String[] args) throws Throwable { >>> 50: >>> 51: // Using the old algorithms to make sure the file is recognized >> >> Do we also want

Re: RFR: 8156071: List.of: reduce array copying during creation

2020-10-06 Thread Stuart Marks
On Tue, 6 Oct 2020 05:07:37 GMT, Tagir F. Valeev wrote: >> Sorry to be late to the party. I thought that all reviews labeled with >> core-libs should be mirrored to core-libs-dev >> mailing list but I haven't seen it there :( >> Please note that the integrated implementation exposes

Integrated: 8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to an expired certificate

2020-10-06 Thread Rajan Halade
On Tue, 6 Oct 2020 16:00:12 GMT, Rajan Halade wrote: > 8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to > an expired certificate This pull request has now been integrated. Changeset: 54b340b4 Author:Rajan Halade URL:

Re: RFR: 8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to an expired certificate [v2]

2020-10-06 Thread Xue-Lei Andrew Fan
On Tue, 6 Oct 2020 16:33:22 GMT, Rajan Halade wrote: >> 8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to >> an expired certificate > > Rajan Halade has updated the pull request incrementally with one additional > commit since the last revision: > > 8254081: Use

Re: RFR: 8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to an expired certificate [v2]

2020-10-06 Thread Sean Mullan
On Tue, 6 Oct 2020 16:29:55 GMT, Rajan Halade wrote: >> 8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to >> an expired certificate > > Rajan Halade has updated the pull request incrementally with one additional > commit since the last revision: > > 8254081: Use

Re: RFR: 8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to an expired certificate [v2]

2020-10-06 Thread Rajan Halade
On Tue, 6 Oct 2020 16:21:34 GMT, Xue-Lei Andrew Fan wrote: >> Rajan Halade has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8254081: Use DateFormat instead of Date > > test/jdk/java/security/cert/PolicyNode/GetPolicyQualifiers.java line

Re: RFR: 8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to an expired certificate [v2]

2020-10-06 Thread Rajan Halade
> 8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to > an expired certificate Rajan Halade has updated the pull request incrementally with one additional commit since the last revision: 8254081: Use DateFormat instead of Date - Changes: - all:

Re: RFR: 8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to an expired certificate

2020-10-06 Thread Xue-Lei Andrew Fan
On Tue, 6 Oct 2020 16:00:12 GMT, Rajan Halade wrote: > 8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to > an expired certificate test/jdk/java/security/cert/PolicyNode/GetPolicyQualifiers.java line 57: > 55: params.setRevocationEnabled(false); > 56:

RFR: 8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to an expired certificate

2020-10-06 Thread Rajan Halade
8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to an expired certificate - Commit messages: - 8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to an expired certificate Changes: https://git.openjdk.java.net/jdk/pull/528/files

RFR: 8253952: Work around wrong usage of ZipOutputStream.putNextEntry() in user code

2020-10-06 Thread Volker Simonis
### Summary Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code which can lead to the `ZipException "invalid entry compressed size"`. ### Motivation In general it is not safe to directly write a ZipEntry obtained from `ZipInputStream.getNextEntry()`, `ZipFile.entries()`,