On Thu, 8 Oct 2020 00:13:37 GMT, Anthony Scarpino wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java line 939:
>>
>>> 937: // if the size of specified output buffer is less than
>>> 938: // the length of the cipher text, then the current
>>> 939
On Fri, 9 Oct 2020 02:38:05 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Xuelei comments
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
> line 614:
>
>> 61
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
This pull request has now been integrated.
Changeset: 0aa3c925
Author:Jonathan Gibbons
URL: https://git.openjdk.java.net/jdk/commit/0aa3c925
Stats:
Compare SunPKCS11 support for AES vs HMAC
* AES => keygen is supported, and AES key can be used for encrypt and
decrypt.
* HMAC => keygen is not supported, but HMAC key can be used for MAC.
This does not make sense. A third-party utility is required for HMAC keygen,
but not for AES keyg
On Mon, 12 Oct 2020 17:35:48 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Xuelei comments
>
> src/java.base/share/classes/com/sun/crypto/provider/GCTR.java line 146:
>
>> 144: private
On Mon, 12 Oct 2020 18:26:14 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Xuelei comments
>
> src/java.base/share/classes/com/sun/crypto/provider/GCTR.java line 165:
>
>> 163: }
>> 164
On Mon, 12 Oct 2020 18:45:28 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Xuelei comments
>
> src/java.base/share/classes/com/sun/crypto/provider/GCTR.java line 237:
>
>> 235:
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
Marked as reviewed by mchung (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/814
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/814
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/814
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
Nice clean-up.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/814
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
As the creator of these tags many moons ago, I approve this change.
-
Marked as reviewed by mr (Lead).
PR: https://git.openjdk.java.net/jdk/pull/81
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
looks fine
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/814
The change is (just) to remove legacy usages of a JDK-private custom tag.
-
Commit messages:
- JDK-8255262: Remove use of legacy custom @spec tag
Changes: https://git.openjdk.java.net/jdk/pull/814/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=814&range=00
Issue: htt
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and associated pull request [3]).
>
> The main goal of this API
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and associated pull request [3]).
>
> The main goal of this API
On Thu, 22 Oct 2020 16:31:00 GMT, Maurizio Cimadamore
wrote:
>> Some of this is familiar to me from reviews in the `panama-foreign`
>> repository, but less so than the memory API. I focused on the Java code, and
>> ignored changes that are common with the memory API PR.
>>
>> If it helps in c
On Wed, 21 Oct 2020 19:05:42 GMT, Paul Sandoz wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge branch 'master' into 8254231_linker
>> - Fix incorrect capitalization in one c
On Thu, 22 Oct 2020 15:46:33 GMT, Paul Sandoz wrote:
>> IIRC this was added to silence a javac linter warning. Something should be
>> added here. There is/was no plan to make this class public though.
>
> It's odd the lint warning is triggering on a package private class and
> private methods.
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and associated pull request [3]).
>
> The main goal of this API
On Wed, 21 Oct 2020 17:42:53 GMT, Paul Sandoz wrote:
> Some design considerations, to consider later maybe.
>
> The IR representation could be simplified to use record classes (which should
> be exiting preview in 16), implementing a Binding interface. The interpreter
> and specializer (compil
On Thu, 22 Oct 2020 14:26:37 GMT, Maurizio Cimadamore
wrote:
>> src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/AbstractNativeScope.java
>> line 120:
>>
>>> 118: }
>>> 119: }
>>> 120: throw new AssertionError("Cannot get here!");
>>
>> This
On Thu, 22 Oct 2020 13:30:13 GMT, Maurizio Cimadamore
wrote:
>> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java
>> line 126:
>>
>>> 124: *
>>> 125: * @param symbol downcall symbol.
>>> 126: * @param type the method type.
>>
>> s/method type/carr
On Thu, 22 Oct 2020 14:31:12 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/java/lang/invoke/NativeMethodHandle.java line 36:
>>
>>> 34: import static java.lang.invoke.MethodHandleStatics.newInternalError;
>>> 35:
>>> 36: /** TODO */
>>
>> Is the TODO to make this class public later an
On Tue, 20 Oct 2020 21:53:55 GMT, Paul Sandoz wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge branch 'master' into 8254231_linker
>> - Fix incorrect capitalization in one c
On Tue, 20 Oct 2020 21:08:26 GMT, Paul Sandoz wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge branch 'master' into 8254231_linker
>> - Fix incorrect capitalization in one c
On Wed, 21 Oct 2020 16:23:16 GMT, Paul Sandoz wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 27 commits:
>>
>> - Merge branch 'master' into 8254231_linker
>> - Don't use JNI when generating native
On Tue, 20 Oct 2020 21:31:17 GMT, Paul Sandoz wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge branch 'master' into 8254231_linker
>> - Fix incorrect capitalization in one c
28 matches
Mail list logo