Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator)

2020-11-03 Thread Alan Bateman
On Mon, 2 Nov 2020 11:26:51 GMT, Maurizio Cimadamore wrote: >> I looked through the changes in this update. >> >> The shared memory segment support looks sound and the mechanism to close a >> shared memory segment is clever (albeit a bit surprising at first that it >> does global handshake to

Re: RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files [v2]

2020-11-03 Thread Valerie Peng
On Tue, 3 Nov 2020 16:58:45 GMT, Weijun Wang wrote: > > > https://github.com/openjdk/jdk/blob/0b37b821a10325d9083c23130e4b8921812ed9c5/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java#L54 > > I cannot add comments to unchanged lines in PKCS11Constants.java

Re: GREASE'd ALPN values - a RFC 8701 / RFC 7301 / JEP 244 discussion

2020-11-03 Thread Bradford Wetmore
On 10/8/2020 9:20 AM, Alexander Scheel wrote: Hi all, I saw that ALPN support from JEP 244 was backported to JDK8 and I've recently had the time to take a closer look at it. For context, I'm one of the maintainers of JSS, a NSS wrapper for Java. I've been discussing this with another contributo

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v3]

2020-11-03 Thread Valerie Peng
On Fri, 23 Oct 2020 16:38:01 GMT, Anthony Scarpino wrote: >> 8253821: Improve ByteBuffer performance with GCM > > Anthony Scarpino has updated the pull request incrementally with six > additional commits since the last revision: > > - style > - style & comments > - full update > - remove o

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v3]

2020-11-03 Thread Valerie Peng
On Fri, 23 Oct 2020 16:38:01 GMT, Anthony Scarpino wrote: >> 8253821: Improve ByteBuffer performance with GCM > > Anthony Scarpino has updated the pull request incrementally with six > additional commits since the last revision: > > - style > - style & comments > - full update > - remove o

JSSE Debug Log redirection

2020-11-03 Thread Bernd
Hello, since the backport of the new TLS 1.3 capable JSSE provider the debug logging of JSSE has changed. This is due to the usage of unified logging, which is not available on Java 8. There are some hints in the backport ticket (16 New Debug Logger): https://bugs.openjdk.java.net/browse/JDK-824

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v3]

2020-11-03 Thread Valerie Peng
On Fri, 23 Oct 2020 16:38:01 GMT, Anthony Scarpino wrote: >> 8253821: Improve ByteBuffer performance with GCM > > Anthony Scarpino has updated the pull request incrementally with six > additional commits since the last revision: > > - style > - style & comments > - full update > - remove o

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v3]

2020-11-03 Thread Anthony Scarpino
On Tue, 3 Nov 2020 01:07:12 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/com/sun/crypto/provider/GCTR.java line 153: >> >>> 151: while (processed > MAX_LEN) { >>> 152: encrypt(in, offset, MAX_LEN, out, 0); >>> 153: dst.get(out, 0, MAX_LE

Re: RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files [v2]

2020-11-03 Thread Weijun Wang
On Mon, 2 Nov 2020 21:33:31 GMT, Weijun Wang wrote: >>> >>> >>> Just curious, can the Java files be generated during the build process? >> >> Hmm, maybe, by the java files, do you just mean PKCS11Constants class or >> more? I am not familiar with how to generate Java files during the build >