Re: RFR: 8255546: Missing coverage for javax.smartcardio.CardPermission and ResponseAPDU

2020-11-08 Thread [email protected]
So you have converted the Test to use JUnit other than adding few new Test cases. It looks fine to me. Thanks, Siba > On 06-Nov-2020, at 6:08 PM, Fernando Guallini > wrote: > > This patch is to add code coverage to the following methods > - javax.smartcardio.CardPermission::**implies** (1)

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-08 Thread Nick Gasson
On Thu, 5 Nov 2020 21:26:16 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393 [

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-08 Thread David Holmes
On Thu, 5 Nov 2020 21:26:16 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393 [

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-08 Thread David Holmes
On Fri, 6 Nov 2020 21:42:41 GMT, Coleen Phillimore wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 64 commits: >> >> - Merge branch '8254162' into 8254231_linker >> - Fix post-merge issues caused by

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v14]

2020-11-08 Thread David Holmes
On Fri, 30 Oct 2020 12:16:02 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-08 Thread David Holmes
On Thu, 5 Nov 2020 21:26:16 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393 [

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v22]

2020-11-08 Thread Alan Bateman
On Thu, 5 Nov 2020 17:14:16 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the third incubation round >> of the foreign memory access API incubation (see JEP 393 [1]). This >> iteration focus on improving the usability of the API in 3 main ways: >> >> * fi

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator)

2020-11-08 Thread Alan Bateman
On Wed, 4 Nov 2020 07:45:09 GMT, Alan Bateman wrote: >>> The javadoc for copyFrom isn't changed in this update but I notice it >>> specifies IndexOutOfBoundException when the source segment is larger than >>> the receiver, have other exceptions been examined? >> >> This exception is consistent