It looks like the break is missed in the loop of the
SSLCipher.createReadCipher() and createWriteCipher() methods. See the change
set.
Code cleanup, no new regression test.
Bug: https://bugs.openjdk.java.net/browse/JDK-8258736
-
Commit messages:
- 8258736: No break in the loop
On Fri, 18 Dec 2020 19:04:36 GMT, Sean Mullan wrote:
>>> MD5 and DES were removed as SE requirements in JDK 14. See
>>> https://bugs.openjdk.java.net/browse/JDK-8214483 for more information.
>>> However, there are no plans to remove the implementations from the JDK at
>>> this time.
>>
>> In
On Fri, 18 Dec 2020 05:55:48 GMT, Xue-Lei Andrew Fan wrote:
> The inner class StatusResponseManager#ResponseCacheEntry could be static, for
> better performance.
>
> Code cleanup, no new regression test.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8258661
This pull request has now been
On Fri, 18 Dec 2020 14:42:38 GMT, PROgrm_JARvis
wrote:
> > MD5 and DES were removed as SE requirements in JDK 14. See
> > https://bugs.openjdk.java.net/browse/JDK-8214483 for more information.
> > However, there are no plans to remove the implementations from the JDK at
> > this time.
>
>
On Fri, 18 Dec 2020 01:05:47 GMT, Xue-Lei Andrew Fan wrote:
> There are a few intermittent timeout in the DTLS regression test in JDK. In
> the DTLS implementation, invalid record is not discarded in the ByteBuffers.
> So, the next unwrap() will repeat the reading and thus there is a
On Fri, 18 Dec 2020 01:05:47 GMT, Xue-Lei Andrew Fan wrote:
> There are a few intermittent timeout in the DTLS regression test in JDK. In
> the DTLS implementation, invalid record is not discarded in the ByteBuffers.
> So, the next unwrap() will repeat the reading and thus there is a
On Thu, 17 Dec 2020 20:45:57 GMT, Roger Riggs wrote:
> The java.util.HexFormat methods for formatting and parsing replace a number
> of adhoc hex parsing and formatting methods in sun.security implementation
> classes.
This pull request has now been integrated.
Changeset: 68f2acbf
Author:
On Fri, 18 Dec 2020 15:48:52 GMT, PROgrm_JARvis
wrote:
>> Might be fun to try, but it looks like rewriting to have MD5 to only use
>> transient state will be a significant effort, and might just end up
>> shuffling over allocations from `getInstance` to `digest`, which could
>> regress code
> Please review this change moving lookup of MD5 digest in `java.lang.UUID` to
> an internal holder class.
PROgrm_JARvis has updated the pull request incrementally with two additional
commits since the last revision:
- 8258588: add Md5MessageDigestLookup benchmark
- 8258588: make
