Re: RFR: 8258852: Arrays.asList() for single item could be replaced with Collections.singletonList()

2020-12-28 Thread Claes Redestad
On Mon, 28 Dec 2020 21:25:57 GMT, Сергей Цыпанов wrote: >>> What about using List.of() instead? >> >> For now, the Collections.singletonList() is more compact, which uses one >> class variable. While List.of(T) shares the internal implementation with >> List.of(T t1, T t2), which uses two cl

Re: RFR: 8258852: Arrays.asList() for single item could be replaced with Collections.singletonList()

2020-12-28 Thread Сергей Цыпанов
On Thu, 24 Dec 2020 17:30:41 GMT, Xue-Lei Andrew Fan wrote: > > What about using List.of() instead? > > For now, the Collections.singletonList() is more compact, which uses one > class variable. While List.of(T) shares the internal implementation with > List.of(T t1, T t2), which uses two clas

Re: Contract of the javax.net.ssl.X509KeyManager.chooseClientAlias method

2020-12-28 Thread Bradford Wetmore
I haven't been following what OpenJDK has been doing recently, but IIRC, the original call includes all of the server's requested key types, copied directly from the CertificateRequest message. See: https://tools.ietf.org/rfcmarkup?doc=2246#section-7.4.4 Have a look at the current code: http

Contract of the javax.net.ssl.X509KeyManager.chooseClientAlias method

2020-12-28 Thread Thomas Fox
Hello, I have a question regarding the contract of the method javax.net.ssl.X509KeyManager.chooseClientAlias(String[] keyType, Principal[] issuers, Socket socket). This method gets called by SSL code on a client when a SSL connection is opened to a server, the server requests client authenticat

RFR: 8258833: Cancel multi-part cipher operations in SunPKCS11 after failures

2020-12-28 Thread Martin Balao
When a multi-part cipher operation fails in SunPKCS11 (i.e. because of an invalid block size), we now cancel the operation before returning the underlying Session to the Session Manager. This allows to use the returned Session for a different purpose. Otherwise, an CKR_OPERATION_ACTIVE error wou