RFR: 8253635: Implement toString() for SSLEngineImpl

2021-01-10 Thread Xue-Lei Andrew Fan
The SSLSocketImpl and SSLEngineImpl implementation does not override the toString() method. The old code did. BTW, I also made a few code clean up in the SSLSocketImpl.java. Code clean up, trivial update, no new regression test. - Commit messages: - missing a white space - 8253

Integrated: 8259385: Cleanup unused assignment

2021-01-10 Thread Xue-Lei Andrew Fan
On Thu, 7 Jan 2021 18:30:27 GMT, Xue-Lei Andrew Fan wrote: > In the SunJSSE provider implementation, there are a few cases that the > assigned value is never used. For example: > int i = 0; > i = Byte.toUnsignedInt(buf.get()); > could be simplified as > `int i = Byte.toUnsignedInt(buf.g

Re: RFR: 8259385: Cleanup unused assignment [v2]

2021-01-10 Thread Xue-Lei Andrew Fan
On Sun, 10 Jan 2021 19:52:24 GMT, Attila Szegedi wrote: > LGTM. Looks like a good ol' IntelliJ IDEA driven fixing (nothing wrong with > that.) Right. > Maybe you could also fix those "temproary" typos while in there? Updated. Thanks! > FWIW, 2 of 3 occurrences of code containing them are almo

Re: RFR: 8259385: Cleanup unused assignment [v2]

2021-01-10 Thread Xue-Lei Andrew Fan
> In the SunJSSE provider implementation, there are a few cases that the > assigned value is never used. For example: > int i = 0; > i = Byte.toUnsignedInt(buf.get()); > could be simplified as > `int i = Byte.toUnsignedInt(buf.get());` > > Code cleanup, no new regression test. Xue-Lei A

Re: RFR: 8259385: Cleanup unused assignment

2021-01-10 Thread Attila Szegedi
On Thu, 7 Jan 2021 18:30:27 GMT, Xue-Lei Andrew Fan wrote: > In the SunJSSE provider implementation, there are a few cases that the > assigned value is never used. For example: > int i = 0; > i = Byte.toUnsignedInt(buf.get()); > could be simplified as > `int i = Byte.toUnsignedInt(buf.g

Re: RFR: 8255255: Update Apache Santuario (XML Signature) to version 2.2.0 [v2]

2021-01-10 Thread Weijun Wang
On Sun, 10 Jan 2021 04:55:38 GMT, Xue-Lei Andrew Fan wrote: >> Weijun Wang has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. > > src/java.xml.crypto/share/classes