Re: RFR: 8259401: Add checking to jarsigner to warn weak algorithms used in si… [v2]

2021-01-12 Thread Hai-May Chao
> The jarsigner tool currently provides warning associated with the signer’s > cert when it uses weak algorithms, but not for the CA certs. This change is > to process the signer’s cert chain to warn if CA certs use weak algorithms. Hai-May Chao has updated the pull request incrementally with

Re: RFR: 8259401: Add checking to jarsigner to warn weak algorithms used in si… [v2]

2021-01-12 Thread Hai-May Chao
On Tue, 12 Jan 2021 22:22:55 GMT, Rajan Halade wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> No warning for trusted cert's SHA1, and added debug output to test > >

Re: RFR: 8259401: Add checking to jarsigner to warn weak algorithms used in si… [v2]

2021-01-12 Thread Hai-May Chao
On Tue, 12 Jan 2021 20:57:41 GMT, Sean Mullan wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> No warning for trusted cert's SHA1, and added debug output to test > > Changes requested by mullan (Reviewer). Thanks

Integrated: 8253635: Implement toString() for SSLEngineImpl

2021-01-12 Thread Xue-Lei Andrew Fan
On Mon, 11 Jan 2021 04:57:19 GMT, Xue-Lei Andrew Fan wrote: > The SSLSocketImpl and SSLEngineImpl implementation does not override the > toString() method. The old code did. BTW, I also made a few code clean up > in the SSLSocketImpl.java. > > Code clean up, trivial update, no new

Re: RFR: 8259498: Reduce overhead of MD5 and SHA digests

2021-01-12 Thread Valerie Peng
On Thu, 7 Jan 2021 18:50:05 GMT, Claes Redestad wrote: >> Removing the UUID clone cache and running the microbenchmark along with the >> changes in #1933: >> >> Benchmark (size) Mode >> CntScoreError Units >>

Re: RFR: 8258833: Cancel multi-part cipher operations in SunPKCS11 after failures

2021-01-12 Thread Valerie Peng
On Tue, 12 Jan 2021 21:38:32 GMT, Martin Balao wrote: > > > > For cipher impls, there are more than just P11Cipher, there are also > > P11AEADCipher and P11RSACipher. It looks like they should be updated with > > this defensive cancellation change unless the non-compliant NSS impl is > >

Re: RFR: 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1 [v3]

2021-01-12 Thread Valerie Peng
> Can someone help review this? > > This change enhances RSA KeyFactory impl of SunRsaSign and SunPKCS11 > providers to accept RSA keys in PKCS#1 format and encoding and translate them > to provider-specific RSA keys. Updated the relevant tests with a sample > PKCS#1 encoded key pair. > >

Re: RFR: 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1 [v2]

2021-01-12 Thread Valerie Peng
> Can someone help review this? > > This change enhances RSA KeyFactory impl of SunRsaSign and SunPKCS11 > providers to accept RSA keys in PKCS#1 format and encoding and translate them > to provider-specific RSA keys. Updated the relevant tests with a sample > PKCS#1 encoded key pair. > >

Re: RFR: 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1

2021-01-12 Thread Valerie Peng
On Tue, 15 Dec 2020 20:29:08 GMT, Valerie Peng wrote: > Can someone help review this? > > This change enhances RSA KeyFactory impl of SunRsaSign and SunPKCS11 > providers to accept RSA keys in PKCS#1 format and encoding and translate them > to provider-specific RSA keys. Updated the relevant

Integrated: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes

2021-01-12 Thread Martin Balao
On Wed, 6 Jan 2021 15:33:59 GMT, Martin Balao wrote: > As described in JDK-8259319 [1], this fix proposal is to set proper access > permissions so the SunPKCS11 provider can create instances of SunJCE classes > when a Security Manager is installed and the fallback scheme is used. > > No

Re: RFR: 8258833: Cancel multi-part cipher operations in SunPKCS11 after failures [v3]

2021-01-12 Thread Martin Balao
On Fri, 8 Jan 2021 20:08:57 GMT, Valerie Peng wrote: >> Because a C_EncryptUpdate call that returns with an error here [1] implies >> that a session (with an active operation) is returned to the Session Manager >> here [2] [3]. For decryption, where we have proper padding on the Java side >>

Re: RFR: 8259401: Add checking to jarsigner to warn weak algorithms used in si…

2021-01-12 Thread Rajan Halade
On Tue, 12 Jan 2021 03:34:00 GMT, Hai-May Chao wrote: > The jarsigner tool currently provides warning associated with the signer’s > cert when it uses weak algorithms, but not for the CA certs. This change is > to process the signer’s cert chain to warn if CA certs use weak algorithms.

Re: RFR: 8259401: Add checking to jarsigner to warn weak algorithms used in si…

2021-01-12 Thread Sean Mullan
On Tue, 12 Jan 2021 03:34:00 GMT, Hai-May Chao wrote: > The jarsigner tool currently provides warning associated with the signer’s > cert when it uses weak algorithms, but not for the CA certs. This change is > to process the signer’s cert chain to warn if CA certs use weak algorithms.

Re: RFR: 8258833: Cancel multi-part cipher operations in SunPKCS11 after failures

2021-01-12 Thread Martin Balao
On Mon, 11 Jan 2021 19:52:16 GMT, Valerie Peng wrote: > For cipher impls, there are more than just P11Cipher, there are also > P11AEADCipher and P11RSACipher. It looks like they should be updated with > this defensive cancellation change unless the non-compliant NSS impl is >

Re: RFR: 8256895: Add support for RFC 8954: Online Certificate Status Protocol… [v2]

2021-01-12 Thread Hai-May Chao
On Tue, 12 Jan 2021 20:10:34 GMT, Rajan Halade wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update to use List.of() and typo changes > >

Re: RFR: 8256895: Add support for RFC 8954: Online Certificate Status Protocol… [v2]

2021-01-12 Thread Rajan Halade
On Tue, 12 Jan 2021 19:18:18 GMT, Hai-May Chao wrote: >> This enhancement adds support for the nonce extension in OCSP request >> extensions by system property jdk.security.certpath.ocspNonce. >> >> Please review the CSR at: >> https://bugs.openjdk.java.net/browse/JDK-8257766 > > Hai-May Chao

Re: RFR: 8256895: Add support for RFC 8954: Online Certificate Status Protocol… [v2]

2021-01-12 Thread Hai-May Chao
On Tue, 12 Jan 2021 16:26:11 GMT, Jamil Nimeh wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update to use List.of() and typo changes > > In general it looks pretty good. Just a couple small comments. Thanks

Re: RFR: 8256895: Add support for RFC 8954: Online Certificate Status Protocol… [v2]

2021-01-12 Thread Hai-May Chao
> This enhancement adds support for the nonce extension in OCSP request > extensions by system property jdk.security.certpath.ocspNonce. > > Please review the CSR at: > https://bugs.openjdk.java.net/browse/JDK-8257766 Hai-May Chao has updated the pull request incrementally with one additional

Re: RFR: 8253635: Implement toString() for SSLEngineImpl [v2]

2021-01-12 Thread Bradford Wetmore
On Tue, 12 Jan 2021 17:19:17 GMT, Xue-Lei Andrew Fan wrote: >> The SSLSocketImpl and SSLEngineImpl implementation does not override the >> toString() method. The old code did. BTW, I also made a few code clean up >> in the SSLSocketImpl.java. >> >> Code clean up, trivial update, no new

Re: RFR: 8253635: Implement toString() for SSLEngineImpl [v2]

2021-01-12 Thread Xue-Lei Andrew Fan
> The SSLSocketImpl and SSLEngineImpl implementation does not override the > toString() method. The old code did. BTW, I also made a few code clean up > in the SSLSocketImpl.java. > > Code clean up, trivial update, no new regression test. Xue-Lei Andrew Fan has updated the pull request with

Re: RFR: 8256895: Add support for RFC 8954: Online Certificate Status Protocol…

2021-01-12 Thread Jamil Nimeh
On Mon, 11 Jan 2021 21:41:56 GMT, Hai-May Chao wrote: > This enhancement adds support for the nonce extension in OCSP request > extensions by system property jdk.security.certpath.ocspNonce. > > Please review the CSR at: > https://bugs.openjdk.java.net/browse/JDK-8257766 In general it looks