On Mon, 25 Jan 2021 23:35:52 GMT, Phil Race wrote:
>> That may actually be a valid concern. Both say macOS 10.12+ ... which might
>> conflict with the 10.9 target.
>
> Maybe you should just file a bug after all for this to be dealt with
> separately.
> Certainly if it is NOT fixed now such a b
Hello,
I wanted to mention again, that all those System property configurations are
good, especially to resolve the update pains, but not really useful if you want
to make configurations on a per-connection base. If you have to support
multiple partners it can be a real pain to setup a common f
On Mon, 25 Jan 2021 23:34:04 GMT, Phil Race wrote:
>> that sounds good to me, I am just afraid to break intel mac on older macos
>> versions with this change.
>
> That may actually be a valid concern. Both say macOS 10.12+ ... which might
> conflict with the 10.9 target.
Maybe you should just
On Mon, 25 Jan 2021 22:47:33 GMT, Vladimir Kempik wrote:
>> 1) I meant change to NSWindowStyleMaskBorderless from NSBorderlessWindowMask
>> 2) So maybe rather than the deprecation suppression you could change both
>> constants to the new ones.
>> Ordinarily I'd say let someone else do that but
On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Mon, 25 Jan 2021 17:08:45 GMT, Fernando Guallini
wrote:
> Fixing manual Test
> "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java".
> It was not handling "weak algorithm" warning during jarsigner output
> verification
Change copyright year to 2021
---
On Mon, 25 Jan 2021 22:45:31 GMT, Hai-May Chao wrote:
>> Marked as reviewed by rhalade (Reviewer).
>
> Looks good.
One comment: Add bug id to the changed test. Thanks.
-
PR: https://git.openjdk.java.net/jdk/pull/2224
On Mon, 25 Jan 2021 22:42:40 GMT, Phil Race wrote:
>> Min_macos version is changed to 11.0 for macos_aarch64
>>
>> https://github.com/openjdk/jdk/pull/2200/files/0c2cb0a372bf1a8607810d773b53d6959616a816#diff-7cd97cdbeb3053597e5d6659016cdf0f60b2c412bd39934a43817ee0b717b7a7R136
>
> 1) I meant chan
On Mon, 25 Jan 2021 21:51:19 GMT, Rajan Halade wrote:
>> Fixing manual Test
>> "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java".
>> It was not handling "weak algorithm" warning during jarsigner output
>> verification
>
> Marked as reviewed by rhalade (Reviewer).
On Mon, 25 Jan 2021 22:25:48 GMT, Vladimir Kempik wrote:
>> Are you doing something somewhere to change the target version of macOS or
>> SDK ? I had no such problem.
>> I think we currently target a macOS 10.9 and if you are changing that it
>> would need discussion.
>> If you are changing it
On Mon, 25 Jan 2021 22:17:56 GMT, Xue-Lei Andrew Fan wrote:
>> The TLS protocols are designed to tolerant unknown TLS extensions. However,
>> although it is not common, there are a few TLS implementations that cannot
>> handle unknown extensions properly. As results in unexpected
>> interopera
On Mon, 25 Jan 2021 22:22:06 GMT, Phil Race wrote:
>> It seems these workarounds are still needed:
>>
>> jdk/src/java.desktop/macosx/native/libsplashscreen/splashscreen_sys.m:300:39:
>> error: 'NSAlphaFirstBitmapFormat' is deprecated: first deprecated in macOS
>> 10.14 [-Werror,-Wdeprecated-de
On Mon, 25 Jan 2021 21:18:59 GMT, Vladimir Kempik wrote:
>> Hello
>> I believe it was a workaround for issues with xcode 12.2 in early beta days.
>> Those issues were fixed later in upstream jdk, so most likely we need to
>> remove these workarounds.
>
> It seems these workarounds are still need
On Mon, 25 Jan 2021 22:17:56 GMT, Xue-Lei Andrew Fan wrote:
>> The TLS protocols are designed to tolerant unknown TLS extensions. However,
>> although it is not common, there are a few TLS implementations that cannot
>> handle unknown extensions properly. As results in unexpected
>> interopera
> The TLS protocols are designed to tolerant unknown TLS extensions. However,
> although it is not common, there are a few TLS implementations that cannot
> handle unknown extensions properly. As results in unexpected interoperability
> issue when new extensions are introduced in JDK. The intero
On Mon, 25 Jan 2021 21:32:18 GMT, Rajan Halade wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright years to 2021
>
> test/jdk/sun/security/ssl/SSLSocketImpl/BlockedExtension.java line 70:
>
>> 6
On Mon, 25 Jan 2021 17:08:45 GMT, Fernando Guallini
wrote:
> Fixing manual Test
> "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java".
> It was not handling "weak algorithm" warning during jarsigner output
> verification
Marked as reviewed by rhalade (Reviewer).
On Fri, 11 Dec 2020 23:20:34 GMT, Xue-Lei Andrew Fan wrote:
> The TLS protocols are designed to tolerant unknown TLS extensions. However,
> although it is not common, there are a few TLS implementations that cannot
> handle unknown extensions properly. As results in unexpected interoperability
On Mon, 25 Jan 2021 20:54:38 GMT, Vladimir Kempik wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 573:
>>
>>> 571: EXTRA_HEADER_DIRS := $(LIBFONTMANAGER_EXTRA_HEADER_DIRS), \
>>> 572: WARNINGS_AS_ERRORS_xlc := false, \
>>> 573: DISABLED_WARNINGS_clang := deprecated-de
On Mon, 25 Jan 2021 19:42:41 GMT, Phil Race wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor CDS disabling
>> - Redo builsys support for aarch64-darwin
>
> make/modules/java.desktop/lib/Awt2dLibraries.gm
On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Mon, 25 Jan 2021 15:01:25 GMT, Anton Kozlov wrote:
>> src/hotspot/share/jfr/instrumentation/jfrJvmtiAgent.cpp line 87:
>>
>>> 85: JavaThread* jt = JavaThread::thread_from_jni_environment(jni_env);
>>> 86: DEBUG_ONLY(JfrJavaSupport::check_java_thread_in_native(jt));;
>>> 87: Thread::WXWr
On Mon, 28 Dec 2020 16:24:43 GMT, Martin Balao wrote:
> When a multi-part cipher operation fails in SunPKCS11 (i.e. because of an
> invalid block size), we now cancel the operation before returning the
> underlying Session to the Session Manager. This allows to use the returned
> Session for a
On Mon, 25 Jan 2021 09:52:00 GMT, Andrew Haley wrote:
>> Hello
>> Why is it not nice ?
>> linux_aarch64 uses some linux specific tls function
>> _ZN10JavaThread25aarch64_get_thread_helperEv from
>> hotspot/os_cpu/linux_aarch64/threadLS_linux_aarch64.s
>> which clobbers only r0 and r1
>> macos_a
On Sun, 24 Jan 2021 15:32:59 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Sun, 24 Jan 2021 15:50:01 GMT, Anton Kozlov wrote:
>> src/hotspot/cpu/aarch64/interpreterRT_aarch64.cpp line 86:
>>
>>> 84:
>>> 85: switch (_num_int_args) {
>>> 86: case 0:
>>
>> I don't think you need such a large switch statement. I think this can be
>> expressed as
>> if (num_int_ar
Fixing manual Test
"ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java".
It was not handling "weak algorithm" warning during jarsigner output
verification
-
Commit messages:
- rename method
- handle warning for SHA-1 weak algorithm
Changes: https://gi
On Mon, 25 Jan 2021 13:30:55 GMT, Vladimir Kempik wrote:
>> make/modules/jdk.hotspot.agent/Lib.gmk line 34:
>>
>>> 32:
>>> 33: else ifeq ($(call isTargetOs, macosx), true)
>>> 34: SA_CFLAGS := -D_GNU_SOURCE -mno-omit-leaf-frame-pointer \
>>
>> Is this really proper for macos-x64? I thought w
On Mon, 25 Jan 2021 14:36:35 GMT, Coleen Phillimore wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
> src/hotspot/share/jfr/instru
On Mon, 25 Jan 2021 14:40:09 GMT, Coleen Phillimore wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
> src/hotspot/share/runtime/th
On Sun, 24 Jan 2021 15:32:59 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Sun, 24 Jan 2021 15:32:59 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Mon, 25 Jan 2021 13:23:27 GMT, Magnus Ihse Bursie wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
> Changes requested by ihse (
On Mon, 25 Jan 2021 14:03:40 GMT, Per Liden wrote:
> In `make/autoconf/jvm-features.m4` I notice that you haven't enabled ZGC for
> macos/aarch64. Is that just an oversight, or is there a reason for that?
because it does not work
processor_id has no "official docs"-friendly implementation, only
On Mon, 25 Jan 2021 13:18:34 GMT, Magnus Ihse Bursie wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
> make/common/NativeCompilati
On Sun, 24 Jan 2021 15:32:59 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Sat, 23 Jan 2021 16:04:53 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/pkcs/PKCS8Key.java line 221:
>>
>>> 219: if (encodedKey == null) {
>>> 220: try {
>>> 221: DerOutputStream tmp = new DerOutputStream();
>>
>> What is the criteria
On Sat, 23 Jan 2021 16:32:16 GMT, Weijun Wang wrote:
>> I'll take a look. The test does not show it. Maybe because of the reversing?
>
> I found out the reason. This method is called during key pair generation but
> my test only deals with manually crafted keys (so that I know what special
> by
On Sat, 23 Jan 2021 16:11:02 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java line
>> 116:
>>
>>> 114: encode();
>>> 115: } catch (IOException e) {
>>> 116: throw new ProviderException("Cannot produce ASN.1
>>> enc
On Sun, 24 Jan 2021 16:10:44 GMT, Anton Kozlov wrote:
>> src/hotspot/cpu/aarch64/interpreterRT_aarch64.cpp line 394:
>>
>>> 392:
>>> 393: class SlowSignatureHandler
>>> 394: : public NativeSignatureIterator {
>>
>> SlowSignatureHandler is turning into a maintenance nightmare. This isn't the
On Sun, 24 Jan 2021 16:29:31 GMT, Vladimir Kempik wrote:
>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5272:
>>
>>> 5270: void MacroAssembler::get_thread(Register dst) {
>>> 5271: RegSet saved_regs = RegSet::range(r0, r1) +
>>> BSD_ONLY(RegSet::range(r2, r17)) + lr - dst;
>>> 527
43 matches
Mail list logo
