Re: RFR: 8257497: Key identifier compliance issue [v3]

2021-02-11 Thread Hai-May Chao
On Thu, 11 Feb 2021 19:48:23 GMT, Weijun Wang wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> API used to get AKID > > src/java.base/share/classes/sun/security/tools/keytool/Main.java line 1482: > >> 1480:

Re: RFR: 8257497: Key identifier compliance issue [v4]

2021-02-11 Thread Hai-May Chao
> This change is made for compliance with RFC 5280 section 4.2.1.1 for > Authority Key Identifier extension. Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision: passing in KeyIdentifier to createV3Extensions - Changes: -

Re: Integrated: 8261472: BasicConstraintsExtension::toString shows "PathLen:2147483647" if there is no pathLenConstraint

2021-02-11 Thread Sean Mullan
Michael, Thanks for the comments - a couple of observations of mine below -- On 2/10/21 12:53 AM, Michael StJohns wrote: On 2/9/2021 9:02 PM, Weijun Wang wrote: On Wed, 10 Feb 2021 01:39:15 GMT, Weijun Wang wrote: Print out "no limit" instead. This is the words RFC 5280 uses: "Where pathLe

Re: RFR: 8257497: Key identifier compliance issue [v3]

2021-02-11 Thread Weijun Wang
On Thu, 11 Feb 2021 01:01:56 GMT, Hai-May Chao wrote: >> This change is made for compliance with RFC 5280 section 4.2.1.1 for >> Authority Key Identifier extension. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > API used

Integrated: JDK-8261510: Use RFC numbers and protocol titles in sun.security.ssl.SSLExtension comments

2021-02-11 Thread John Jiang
On Wed, 10 Feb 2021 21:22:03 GMT, John Jiang wrote: > This is a simple cleanup for sun.security.ssl.SSLExtension. > The comments for the extension groups would use the RFC numbers and the > protocol titles correspondingly. > It also removes a trailing space in extension token_binding, and move

Re: RFR: JDK-8261510: Use RFC numbers and protocol titles in sun.security.ssl.SSLExtension comments [v3]

2021-02-11 Thread Xue-Lei Andrew Fan
On Thu, 11 Feb 2021 10:10:58 GMT, John Jiang wrote: >> This is a simple cleanup for sun.security.ssl.SSLExtension. >> The comments for the extension groups would use the RFC numbers and the >> protocol titles correspondingly. >> It also removes a trailing space in extension token_binding, and mo

Re: RFR: 8261160: Add a deserialization JFR event [v4]

2021-02-11 Thread Roger Riggs
On Thu, 11 Feb 2021 15:53:06 GMT, Chris Hegarty wrote: >> This issue adds a new event to improve diagnostic information of Java >> deserialization. The event captures the details of deserialization activity >> from ObjectInputStream. The event details are similar to that of the serial >> filte

Re: RFR: 8261160: Add a deserialization JFR event [v4]

2021-02-11 Thread Daniel Fuchs
On Thu, 11 Feb 2021 15:53:06 GMT, Chris Hegarty wrote: >> This issue adds a new event to improve diagnostic information of Java >> deserialization. The event captures the details of deserialization activity >> from ObjectInputStream. The event details are similar to that of the serial >> filte

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v17]

2021-02-11 Thread Jim Laskey
> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at > http://cr.openjdk.java.net/~jlaskey/prng/doc/a

Re: RFR: JDK-8261510: Use RFC numbers and protocol titles in sun.security.ssl.SSLExtension comments [v3]

2021-02-11 Thread Bradford Wetmore
On Thu, 11 Feb 2021 10:10:58 GMT, John Jiang wrote: >> This is a simple cleanup for sun.security.ssl.SSLExtension. >> The comments for the extension groups would use the RFC numbers and the >> protocol titles correspondingly. >> It also removes a trailing space in extension token_binding, and mo

Re: RFR: 8261160: Add a deserialization JFR event [v3]

2021-02-11 Thread Chris Hegarty
On Thu, 11 Feb 2021 15:45:33 GMT, Daniel Fuchs wrote: >> Chris Hegarty has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix failing test > > src/jdk.jfr/share/classes/jdk/jfr/events/DeserializationEvent.java line 42: > >> 40: >> 41:

Re: RFR: 8261160: Add a deserialization JFR event [v4]

2021-02-11 Thread Chris Hegarty
> This issue adds a new event to improve diagnostic information of Java > deserialization. The event captures the details of deserialization activity > from ObjectInputStream. The event details are similar to that of the serial > filter, but is agnostic of whether a filter is installed or not. T

Re: RFR: 8261160: Add a deserialization JFR event [v3]

2021-02-11 Thread Daniel Fuchs
On Thu, 11 Feb 2021 15:28:07 GMT, Chris Hegarty wrote: >> This issue adds a new event to improve diagnostic information of Java >> deserialization. The event captures the details of deserialization activity >> from ObjectInputStream. The event details are similar to that of the serial >> filte

Re: RFR: 8261160: Add a deserialization JFR event [v3]

2021-02-11 Thread Sean Coffey
On Thu, 11 Feb 2021 15:28:07 GMT, Chris Hegarty wrote: >> This issue adds a new event to improve diagnostic information of Java >> deserialization. The event captures the details of deserialization activity >> from ObjectInputStream. The event details are similar to that of the serial >> filte

Re: RFR: 8261160: Add a deserialization JFR event [v3]

2021-02-11 Thread Chris Hegarty
> This issue adds a new event to improve diagnostic information of Java > deserialization. The event captures the details of deserialization activity > from ObjectInputStream. The event details are similar to that of the serial > filter, but is agnostic of whether a filter is installed or not. T

Re: RFR: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset [v5]

2021-02-11 Thread Daniel Fuchs
On Thu, 11 Feb 2021 12:39:54 GMT, Fernando Guallini wrote: >> The server side is binding to the wildcard address which has been a source >> of instability in many networking tests due to javax.net.ssl.SSLException: >> Connection reset. Changing the following tests to bind to loopback address

Re: RFR: 8261160: Add a deserialization JFR event [v2]

2021-02-11 Thread Chris Hegarty
On Thu, 11 Feb 2021 14:27:19 GMT, Roger Riggs wrote: >> Marked as reviewed by rriggs (Reviewer). > > As proposed, events are only created if there is a serialFilter in effect > (and enabled by JFR configuration). > Being able to create the events without a serialFilter in effect would be > usef

Re: RFR: 8261160: Add a deserialization JFR event [v2]

2021-02-11 Thread Chris Hegarty
> This issue adds a new event to improve diagnostic information of Java > deserialization. The event captures the details of deserialization activity > from ObjectInputStream. The event details are similar to that of the serial > filter, but is agnostic of whether a filter is installed or not. T

Re: RFR: 8261160: Add a deserialization JFR event

2021-02-11 Thread Roger Riggs
On Wed, 10 Feb 2021 20:30:02 GMT, Roger Riggs wrote: >> This issue adds a new event to improve diagnostic information of Java >> deserialization. The event captures the details of deserialization activity >> from ObjectInputStream. The event details are similar to that of the serial >> filter,

Re: RFR: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset [v4]

2021-02-11 Thread Fernando Guallini
On Thu, 11 Feb 2021 12:17:41 GMT, Daniel Fuchs wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> check exception type > > test/jdk/javax/net/ssl/SSLSession/TestEnabledProtocols.java line 155: > >> 153:

Re: RFR: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset [v5]

2021-02-11 Thread Fernando Guallini
> The server side is binding to the wildcard address which has been a source of > instability in many networking tests due to javax.net.ssl.SSLException: > Connection reset. Changing the following tests to bind to loopback address > fixes intermittent failures: > sun/security/ssl/SSLSocketImpl/R

Re: RFR: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset [v4]

2021-02-11 Thread Daniel Fuchs
On Thu, 11 Feb 2021 12:08:54 GMT, Fernando Guallini wrote: >> The server side is binding to the wildcard address which has been a source >> of instability in many networking tests due to javax.net.ssl.SSLException: >> Connection reset. Changing the following tests to bind to loopback address

Re: RFR: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset [v3]

2021-02-11 Thread Fernando Guallini
On Wed, 10 Feb 2021 12:24:15 GMT, Daniel Fuchs wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> narrow down connection reset handling > > test/jdk/javax/net/ssl/SSLSession/TestEnabledProtocols.java line 142: >

Re: RFR: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset [v4]

2021-02-11 Thread Fernando Guallini
> The server side is binding to the wildcard address which has been a source of > instability in many networking tests due to javax.net.ssl.SSLException: > Connection reset. Changing the following tests to bind to loopback address > fixes intermittent failures: > sun/security/ssl/SSLSocketImpl/R

Re: RFR: JDK-8261510: Use RFC numbers and protocol titles in sun.security.ssl.SSLExtension comments [v3]

2021-02-11 Thread John Jiang
> This is a simple cleanup for sun.security.ssl.SSLExtension. > The comments for the extension groups would use the RFC numbers and the > protocol titles correspondingly. > It also removes a trailing space in extension token_binding, and move > signature_algorithms and signature_algorithms_cert t