Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v3]

2021-02-26 Thread Roger Riggs
On Wed, 25 Nov 2020 16:22:32 GMT, Jim Laskey wrote: >> src/java.base/share/classes/java/util/random/RandomGeneratorFactory.java >> line 106: >> >>> 104: * Map of provider classes. >>> 105: */ >>> 106: private static volatile Map>> RandomGenerator>> factoryMap; >> >> should be FAC

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v25]

2021-02-26 Thread Roger Riggs
On Tue, 23 Feb 2021 16:47:59 GMT, Jim Laskey wrote: >> This PR is to introduce a new random number API for the JDK. The primary API >> is found in RandomGenerator and RandomGeneratorFactory. Further description >> can be found in the JEP https://openjdk.java.net/jeps/356 . >> >> javadoc can be

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v21]

2021-02-26 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8262438: sun/security/ssl/SSLLogger/LoggingFormatConsistency.java failed with "SocketException: Socket is closed"

2021-02-26 Thread Daniel Fuchs
On Fri, 26 Feb 2021 14:28:23 GMT, Evan Whelan wrote: > Hi all, > > Please review my test fix relating to JDK-8262438 > > This patch introduces as Thread.sleep at the start of each iteration which > creates a new test jvm. > This allows the server socket sufficient time to release the previous

Integrated: 8259535: ECDSA SignatureValue do not always have the specified length

2021-02-26 Thread Weijun Wang
On Fri, 12 Feb 2021 15:24:07 GMT, Weijun Wang wrote: > The code change fixes the ECDSA XML signature length issue. It should only > happen when there is no P1363 ECDSA support, which is not true when SunEC is > used. > > If a PrivateKey is not of ECPrivateKey type then the bug will still show

Re: RFR: 8259535: ECDSA SignatureValue do not always have the specified length

2021-02-26 Thread Sean Mullan
On Fri, 26 Feb 2021 15:34:42 GMT, Weijun Wang wrote: >> src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureECDSA.java >> line 68: >> >>> 66: * >>> 67: * @param asn1Bytes >>> 68: * @param rawLen >> >> You should add the

Re: RFR: 8259535: ECDSA SignatureValue do not always have the specified length

2021-02-26 Thread Weijun Wang
On Thu, 25 Feb 2021 21:23:51 GMT, Sean Mullan wrote: >> The code change fixes the ECDSA XML signature length issue. It should only >> happen when there is no P1363 ECDSA support, which is not true when SunEC is >> used. >> >> If a PrivateKey is not of ECPrivateKey type then the bug will still

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-26 Thread erik . joelsson
On 2021-02-26 06:37, daniel.daughe...@oracle.com wrote: On 2/26/21 7:55 AM, Vladimir Kempik wrote: On Tue, 2 Feb 2021 23:07:08 GMT, Daniel D. Daugherty wrote: Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:    support macos_aarc

Re: RFR: 8259535: ECDSA SignatureValue do not always have the specified length

2021-02-26 Thread Sean Mullan
On Fri, 12 Feb 2021 15:24:07 GMT, Weijun Wang wrote: > The code change fixes the ECDSA XML signature length issue. It should only > happen when there is no P1363 ECDSA support, which is not true when SunEC is > used. > > If a PrivateKey is not of ECPrivateKey type then the bug will still show

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-26 Thread daniel . daugherty
On 2/26/21 7:55 AM, Vladimir Kempik wrote: On Tue, 2 Feb 2021 23:07:08 GMT, Daniel D. Daugherty wrote: Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision: support macos_aarch64 in hsdis src/java.base/macosx/native/libjli/java_md_mac

RFR: 8262438: sun/security/ssl/SSLLogger/LoggingFormatConsistency.java failed with "SocketException: Socket is closed"

2021-02-26 Thread Evan Whelan
Hi all, Please review my test fix relating to JDK-8262438 This patch introduces as Thread.sleep at the start of each iteration which creates a new test jvm. This allows the server socket sufficient time to release the previous connection and allows the port to be used again. I also refactored

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators

2021-02-26 Thread Rémi Forax
On Fri, 26 Feb 2021 13:13:19 GMT, Jim Laskey wrote: >> Stayin' alive > > Looking for some final code reviews. I still don't like the fact that the factory uses reflection but i don't see how to do better - PR: https://git.openjdk.java.net/jdk/pull/1292

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators

2021-02-26 Thread Jim Laskey
On Mon, 4 Jan 2021 13:54:14 GMT, Jim Laskey wrote: >> This PR is to introduce a new random number API for the JDK. The primary API >> is found in RandomGenerator and RandomGeneratorFactory. Further description >> can be found in the JEP https://openjdk.java.net/jeps/356 . >> >> javadoc can be

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-26 Thread Vladimir Kempik
On Tue, 2 Feb 2021 23:07:08 GMT, Daniel D. Daugherty wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> support macos_aarch64 in hsdis > > src/java.base/macosx/native/libjli/java_md_macosx.m line 210: > >> 208: i

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v20]

2021-02-26 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v19]

2021-02-26 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

RFR: 8260923: Add more tests for SSLSocket input/output shutdown

2021-02-26 Thread Abdul Kolarkunnu
There is a lack of tests in the area of java.net.Socket.shutdownInput() and java.net.Socket.shutdownOutput() , so added more tests in this area of with different TLS versions. Please review. - Commit messages: - 8260923: Add more tests for SSLSocket input/output shutdown Changes: