Re: RFR: 8263978: Clarify why 0 argument is ignored in SecureRandom::setSeed [v2]

On Mon, 22 Mar 2021 18:06:56 GMT, Weijun Wang wrote: >> We don't use `digest` anymore but still need to ignore the 0 argument. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > typo Marked as reviewed by valeriep (Reviewer).

Re: RFR: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec [v4]

On Sat, 20 Mar 2021 19:24:45 GMT, SalusaSecondus wrote: >> We seem to have a choice and I'm not sure the best way to approach this. >> >> 1. We trust the properties in `P11Key` and just ask it if the values are >> both sensitive and extractable. [1] >> 2. But if we already trust P11Key, why

Re: RFR: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec [v4]

On Sat, 20 Mar 2021 17:41:45 GMT, SalusaSecondus wrote: >> I think that this code will work, but since there already is >> [P11RSAPrivateKey and >>

Re: RFR: 8248268: Support KWP in addition to KW [v3]

> This change updates SunJCE provider as below: > - updated existing AESWrap support with AES/KW/NoPadding cipher > transformation. > - added support for AES/KWP/NoPadding and AES/KW/PKCS5Padding. > > Existing AESWrap impl, i.e. AESWrapCipher class, is re-factored and renamed > to

Re: RFR: 8263978: Clarify why 0 argument is ignored in SecureRandom::setSeed [v2]

On Mon, 22 Mar 2021 18:40:37 GMT, Valerie Peng wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> typo > > src/java.base/share/classes/java/security/SecureRandom.java line 739: > >> 737: * to actually do any

Re: RFR: 8248268: Support KWP in addition to KW

On Thu, 4 Feb 2021 10:51:12 GMT, Valerie Peng wrote: > This change updates SunJCE provider as below: > - updated existing AESWrap support with AES/KW/NoPadding cipher > transformation. > - added support for AES/KWP/NoPadding and AES/KW/PKCS5Padding. > > Existing AESWrap impl, i.e.

Re: RFR: 8263978: Clarify why 0 argument is ignored in SecureRandom::setSeed [v2]

On Mon, 22 Mar 2021 18:06:56 GMT, Weijun Wang wrote: >> We don't use `digest` anymore but still need to ignore the 0 argument. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > typo

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v34]

> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at >

Re: RFR: 8263978: Clarify why 0 argument is ignored in SecureRandom::setSeed [v2]

> We don't use `digest` anymore but still need to ignore the 0 argument. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: typo - Changes: - all: https://git.openjdk.java.net/jdk/pull/3124/files - new:

Re: RFR: 8225438: javax/net/ssl/TLSCommon/TestSessionLocalPrincipal.java failed with Read timed out

On Mon, 22 Mar 2021 10:45:34 GMT, Sibabrata Sahoo wrote: > The Test getting timeout intermittently because the SO_TIMEOUT of 5 seconds > set on sslServerSocket. This time interval could be inadequate when the > machine is too busy. Also it looks setting SO_TIMEOUT is unnecessary here. So >

Re: RFR: 8247895: SHA1PRNGReseed.java is calling setSeed(0)

On Mon, 22 Mar 2021 10:30:07 GMT, Sibabrata Sahoo wrote: > The Test is updated to use positive integer as seed for SecureRandom. Marked as reviewed by rhalade (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3114

Re: RFR: 8225438: javax/net/ssl/TLSCommon/TestSessionLocalPrincipal.java failed with Read timed out

On Mon, 22 Mar 2021 10:45:34 GMT, Sibabrata Sahoo wrote: > The Test getting timeout intermittently because the SO_TIMEOUT of 5 seconds > set on sslServerSocket. This time interval could be inadequate when the > machine is too busy. Also it looks setting SO_TIMEOUT is unnecessary here. So >

Re: RFR: 8225438: javax/net/ssl/TLSCommon/TestSessionLocalPrincipal.java failed with Read timed out

On Mon, 22 Mar 2021 10:45:34 GMT, Sibabrata Sahoo wrote: > The Test getting timeout intermittently because the SO_TIMEOUT of 5 seconds > set on sslServerSocket. This time interval could be inadequate when the > machine is too busy. Also it looks setting SO_TIMEOUT is unnecessary here. So >

RFR: 8263978: Clarify why 0 argument is ignored in SecureRandom::setSeed

We don't use `digest` anymore but still need to ignore the 0 argument. - Commit messages: - 8263978: Clarify why 0 argument is ignored in SecureRandom::setSeed Changes: https://git.openjdk.java.net/jdk/pull/3124/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3124=00

Re: RFR: 8247895: SHA1PRNGReseed.java is calling setSeed(0)

On Mon, 22 Mar 2021 10:30:07 GMT, Sibabrata Sahoo wrote: > The Test is updated to use positive integer as seed for SecureRandom. Marked as reviewed by weijun (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3114

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v32]

On Thu, 18 Mar 2021 21:43:16 GMT, Joe Darcy wrote: >> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 67 commits: >> >> - Merge branch 'master' into 8248862 >> - Review revisions >> - Missing @since >> - Review

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v33]

> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at >

Integrated: 8263855: Use the blessed modifier order in java.management/naming

On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt wrote: > As with #2993 changing the order of `final static` to `static final` for the > `java.management`, `java.management.rmi` and `java.naming` modules. This pull request has now been integrated. Changeset: 5262d95b Author:Alex Blewitt

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming [v2]

On Fri, 19 Mar 2021 17:13:58 GMT, Alex Blewitt wrote: >> As with #2993 changing the order of `final static` to `static final` for the >> `java.management`, `java.management.rmi` and `java.naming` modules. > > Alex Blewitt has updated the pull request incrementally with one additional > commit

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v29]

> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming [v2]

On Fri, 19 Mar 2021 17:13:58 GMT, Alex Blewitt wrote: >> As with #2993 changing the order of `final static` to `static final` for the >> `java.management`, `java.management.rmi` and `java.naming` modules. > > Alex Blewitt has updated the pull request incrementally with one additional > commit

RFR: 8225438: javax/net/ssl/TLSCommon/TestSessionLocalPrincipal.java failed with Read timed out

The Test getting timeout intermittently because the SO_TIMEOUT of 5 seconds set on sslServerSocket. This time interval could be inadequate when the machine is too busy. Also it looks setting SO_TIMEOUT is unnecessary here. So the statement has been removed. - Commit messages: -

RFR: 8247895: SHA1PRNGReseed.java is calling setSeed(0)

The Test is updated to use positive integer as seed for SecureRandom. - Commit messages: - 8247895: SHA1PRNGReseed.java is calling setSeed(0) Changes: https://git.openjdk.java.net/jdk/pull/3114/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3114=00 Issue: