JEP411: Missing use-case: Monitoring / restricting libraries

2021-04-15 Thread Reinier Zwitserloot
One useful thing that you can do with SecurityManager, which would be impossible if it is removed, and which isn't described in the 'specific narrow use cases' section: Monitoring and restriction of, specifically, third party libraries. 99 out of a 100 modern java projects have a rather long

Re: RFR: 8265237: String.join and StringJoiner can be improved further

2021-04-15 Thread Peter Levart
On Wed, 14 Apr 2021 20:03:27 GMT, Claes Redestad wrote: > There's a StringJoinerBenchmark micro added by JDK-8148937 which could > perhaps be expanded with the scenarios you've experimented with here? I modified that micro benchmark and added a method to also measure String.join static method

Re: RFR: 8265237: String.join and StringJoiner can be improved further [v2]

2021-04-15 Thread Peter Levart
> While JDK-8148937 improved StringJoiner class by replacing internal use of > getChars that copies out characters from String elements into a char[] array > with StringBuilder which is somehow more optimal, the improvement was > marginal in speed (0% ... 10%) and mainly for smaller strings,

Re: RFR: 8185127: Add Tests to cover hashCode() method for java supported crypto key types. [v2]

2021-04-15 Thread Valerie Peng
On Wed, 14 Apr 2021 17:37:00 GMT, Sibabrata Sahoo wrote: >> This is a simple Test to add few additional API coverage for all java >> supported key types. The objective of this Test is to cover equals() and >> hashcode() methods for each key types. > > Sibabrata Sahoo has updated the pull

Re: RFR: 8264208: Console charset API [v8]

2021-04-15 Thread Naoto Sato
On Thu, 15 Apr 2021 14:17:11 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added @see links. > > src/java.base/share/classes/java/io/Console.java line 397: > >> 395: /** >> 396: *

Re: RFR: 8185127: Add Tests to cover hashCode() method for java supported crypto key types. [v2]

2021-04-15 Thread Valerie Peng
On Thu, 15 Apr 2021 18:18:07 GMT, Valerie Peng wrote: >> Sibabrata Sahoo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Comment changed. >> >> Comment changed. > > test/jdk/javax/crypto/KeyGenerator/CompareKeys.java line 73: > >>

Re: RFR: 8264208: Console charset API [v9]

2021-04-15 Thread Naoto Sato
> Please review the changes for the subject issue. This has been suggested in > a recent discussion thread for the JEP 400 > [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. > A CSR has also been drafted, and comments are welcome >

Re: RFR: 8185127: Add Tests to cover hashCode() method for java supported crypto key types. [v2]

2021-04-15 Thread Valerie Peng
On Wed, 14 Apr 2021 17:37:00 GMT, Sibabrata Sahoo wrote: >> This is a simple Test to add few additional API coverage for all java >> supported key types. The objective of this Test is to cover equals() and >> hashcode() methods for each key types. > > Sibabrata Sahoo has updated the pull

Re: RFR: 8185127: Add Tests to cover hashCode() method for java supported crypto key types. [v2]

2021-04-15 Thread Valerie Peng
On Wed, 14 Apr 2021 17:37:00 GMT, Sibabrata Sahoo wrote: >> This is a simple Test to add few additional API coverage for all java >> supported key types. The objective of this Test is to cover equals() and >> hashcode() methods for each key types. > > Sibabrata Sahoo has updated the pull

New candidate JEP: 411: Deprecate the Security Manager for Removal

2021-04-15 Thread mark . reinhold
https://openjdk.java.net/jeps/411 Summary: Deprecate the Security Manager for removal in a future release. The Security Manager dates from Java 1.0. It has not been the primary means of securing client-side Java code for many years, and it has rarely been used to secure server-side code.

Integrated: 8265227: Move Proc.java from security/testlibrary to test/lib

2021-04-15 Thread Weijun Wang
On Wed, 14 Apr 2021 18:12:57 GMT, Weijun Wang wrote: > I'd like to move this tool to test/lib inside a proper named package. This pull request has now been integrated. Changeset: c70589c6 Author:Weijun Wang URL: https://git.openjdk.java.net/jdk/commit/c70589c6 Stats: 119 lines

Re: RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3]

2021-04-15 Thread Jamil Nimeh
On Wed, 14 Apr 2021 03:58:33 GMT, Valerie Peng wrote: >> Could someone (perhaps Jamil?) please help review this change? This enhances >> SunPKCS11 provider with ChaCha20-Poly1305 cipher and ChaCha20 key generation >> support. Majority of the regression tests are adapted from the existing ones

Re: RFR: 8264208: Console charset API [v8]

2021-04-15 Thread Alan Bateman
On Wed, 14 Apr 2021 17:17:03 GMT, Naoto Sato wrote: >> Please review the changes for the subject issue. This has been suggested in >> a recent discussion thread for the JEP 400 >> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. >> A CSR has also been

Re: RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3]

2021-04-15 Thread Jamil Nimeh
On Wed, 14 Apr 2021 03:58:33 GMT, Valerie Peng wrote: >> Could someone (perhaps Jamil?) please help review this change? This enhances >> SunPKCS11 provider with ChaCha20-Poly1305 cipher and ChaCha20 key generation >> support. Majority of the regression tests are adapted from the existing ones

Re: RFR: 8265227: Move Proc.java from security/testlibrary to test/lib [v3]

2021-04-15 Thread Roger Riggs
On Wed, 14 Apr 2021 22:57:55 GMT, Weijun Wang wrote: >> I'd like to move this tool to test/lib inside a proper named package. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > do not call internal method Marked as reviewed

Integrated: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI

2021-04-15 Thread Conor Cleary
On Fri, 9 Apr 2021 13:15:16 GMT, Conor Cleary wrote: > ### Description > This fix is part of a previous effort to both cleanup/modernise JNDI code, > the details of which can be seen in > [JDK-8048091](https://bugs.openjdk.java.net/browse/JDK-8048091). A number > JNDI methods under

Re: RFR: 8265237: String.join and StringJoiner can be improved further

2021-04-15 Thread Florent Guillaume
On Wed, 14 Apr 2021 22:23:57 GMT, Peter Levart wrote: >> src/java.base/share/classes/java/lang/String.java line 3230: >> >>> 3228: >>> 3229: /** >>> 3230: * Designated join routine. >> >> Did you mean "dedicated"? > > No, I meant designated. It is the routine that all other public

Re: RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3]

2021-04-15 Thread Sibabrata Sahoo
On Wed, 14 Apr 2021 03:58:33 GMT, Valerie Peng wrote: >> Could someone (perhaps Jamil?) please help review this change? This enhances >> SunPKCS11 provider with ChaCha20-Poly1305 cipher and ChaCha20 key generation >> support. Majority of the regression tests are adapted from the existing ones

Re: RFR: 8265227: Move Proc.java from security/testlibrary to test/lib [v3]

2021-04-15 Thread Sibabrata Sahoo
On Wed, 14 Apr 2021 22:57:55 GMT, Weijun Wang wrote: >> I'd like to move this tool to test/lib inside a proper named package. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > do not call internal method Marked as reviewed