Re: RFR: 8264208: Console charset API [v10]

2021-04-16 Thread Naoto Sato
> Please review the changes for the subject issue. This has been suggested in > a recent discussion thread for the JEP 400 > [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. > A CSR has also been drafted, and comments are welcome >

Re: RFR: 8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params [v7]

2021-04-16 Thread Sean Mullan
On Tue, 13 Apr 2021 18:16:30 GMT, Weijun Wang wrote: >> This enhancement contains the following code changes: >> >> 1. Create a new public API `javax/xml/crypto/dsig/spec/RSAPSSParameterSpec` >> and remove the internal one. >> 2. Update marshaling and unmarshaling code inside

Re: JEP411: Missing use-case: Monitoring / restricting libraries

2021-04-16 Thread Mark Raynsford
On 2021-04-16T17:02:06 -0400 Sean Mullan wrote: > > That said, I think it is worth exploring (in this JEP) or another JEP > ways that we might think about that could help provide DiD protection > for network and file access. This is an opportunity to look at the > problem with a fresh set of

Re: JEP411: Missing use-case: Monitoring / restricting libraries

2021-04-16 Thread Ron Pressler
I think it’s worth adding that treating libraries as untrusted code is unworkable over the long run, as their set of permissions possibly needs to be reexamined with every update. On the other hand, JFR can serve as a mechanism for tracing application behaviour, which, when streamed, can serve

Re: JEP411: Missing use-case: Monitoring / restricting libraries

2021-04-16 Thread Sean Mullan
Hello Reinier, Thanks for the feedback on the JEP. If I read your message correctly, you seem to be primarily concerned with logging and/or restricting access to file and network operations. In my personal view, some of the examples you present that do somewhat sketchy things are probably

Re: RFR: 8264208: Console charset API [v9]

2021-04-16 Thread Naoto Sato
On Fri, 16 Apr 2021 18:15:41 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Modified javadocs per suggestions. > > src/java.base/share/classes/java/io/InputStreamReader.java line 48: > >> 46: *

Re: RFR: 8264208: Console charset API [v9]

2021-04-16 Thread Roger Riggs
On Thu, 15 Apr 2021 18:29:17 GMT, Naoto Sato wrote: >> Please review the changes for the subject issue. This has been suggested in >> a recent discussion thread for the JEP 400 >> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. >> A CSR has also been

Integrated: 8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out

2021-04-16 Thread Fernando Guallini
On Tue, 13 Apr 2021 13:19:17 GMT, Fernando Guallini wrote: > test/jdk/javax/net/ssl/DTLS/RespondToRetransmit.java has been seen to fail > intermittently. > The server side is binding to the wildcard/localhost address which has been a > source of instability in many tests. Binding to loopback

RFR: 8240256: Better resource cleaning for SunPKCS11 Provider

2021-04-16 Thread Sean Coffey
Added capability to allow the PKCS11 Token to be destroyed once a session is logged out from. New configuration properties via pkcs11 config file. Cleaned up the native resource poller also. New unit test case to test behaviour. Some PKCS11 tests refactored to allow pkcs11 provider to be

Withdrawn: 8185127: Add tests to cover hashCode() method for java supported crypto key types

2021-04-16 Thread Sibabrata Sahoo
On Wed, 14 Apr 2021 13:38:06 GMT, Sibabrata Sahoo wrote: > This is a simple Test to add few additional API coverage for all java > supported key types. The objective of this Test is to cover equals() and > hashcode() methods for each key types. This pull request has been closed without being

Re: RFR: 8185127: Add tests to cover hashCode() method for java supported crypto key types [v4]

2021-04-16 Thread Sibabrata Sahoo
On Fri, 16 Apr 2021 08:34:11 GMT, Sibabrata Sahoo wrote: >> This is a simple Test to add few additional API coverage for all java >> supported key types. The objective of this Test is to cover equals() and >> hashcode() methods for each key types. > > Sibabrata Sahoo has updated the pull

Re: RFR: 8185127: Add Tests to cover hashCode() method for java supported crypto key types. [v4]

2021-04-16 Thread Sibabrata Sahoo
> This is a simple Test to add few additional API coverage for all java > supported key types. The objective of this Test is to cover equals() and > hashcode() methods for each key types. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8185127: Add Tests to cover hashCode() method for java supported crypto key types. [v3]

2021-04-16 Thread Sibabrata Sahoo
> This is a simple Test to add few additional API coverage for all java > supported key types. The objective of this Test is to cover equals() and > hashcode() methods for each key types. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8185127: Add Tests to cover hashCode() method for java supported crypto key types. [v2]

2021-04-16 Thread Sibabrata Sahoo
On Thu, 15 Apr 2021 18:32:26 GMT, Valerie Peng wrote: >> test/jdk/javax/crypto/KeyGenerator/CompareKeys.java line 73: >> >>> 71: && !Arrays.equals(origKey.getEncoded(), >>> copyKey.getEncoded()) >>> 72: && origKey.hashCode() != copyKey.hashCode()) { >>> 73:

Re: RFR: 8185127: Add Tests to cover hashCode() method for java supported crypto key types. [v2]

2021-04-16 Thread Sibabrata Sahoo
On Thu, 15 Apr 2021 18:23:09 GMT, Valerie Peng wrote: >> Sibabrata Sahoo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Comment changed. >> >> Comment changed. > > test/jdk/javax/crypto/KeyGenerator/CompareKeys.java line 114: >