RFR: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java

2021-05-10 Thread Xue-Lei Andrew Fan
Hi, May I have the following test code reviewed? The test SSLEngineExplorerMatchedSNI.java fails intermittently. I tried to run the test 500 times, but cannot reproduce the issue. The cause is unknown to me now. It would could be helpful to fine the root cause to enable the JSSE debugging in

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v3]

2021-05-10 Thread Maurizio Cimadamore
On Fri, 30 Apr 2021 17:20:21 GMT, Mandy Chung wrote: >>> I think the implementation does not support that. I will also need to look >>> into how this impacts JDK-8266010. As I suggest earlier, I'm fine to do >>> this as a follow up after integration. >> >> I've added `@CS` in the interface met

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v16]

2021-05-10 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-412 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/412 Maurizio Cimadamore has updated the pull request

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v15]

2021-05-10 Thread Mandy Chung
On Mon, 10 May 2021 18:15:01 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-412 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjd

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v15]

2021-05-10 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-412 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/412 Maurizio Cimadamore has updated the pull request

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v14]

2021-05-10 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-412 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/412 Maurizio Cimadamore has updated the pull request

Re: RFR: 8164804: sun/security/ssl/SSLSocketImpl/CloseSocket.java makes not reliable time assumption [v2]

2021-05-10 Thread Rajan Halade
On Wed, 5 May 2021 11:13:13 GMT, Daniel Fuchs wrote: >> Thanks, updated to be volatile. >> >> SSLSocket::startHandshake internally first checks that the socket is not >> closed or broken and still connected, so it needs the server to close the >> socket after those verifications are performed

Re: Ping? [8u] RFR: 8206925: Support the certificate_authorities extension

2021-05-10 Thread Mario Torre
Hi Severin, I went through the patch and it looks good to me. Cheers, Mario On Mon, May 10, 2021 at 4:13 PM Severin Gehwolf wrote: > > Hi! > > Would anyone be willing to review this? > > Many thanks in advance! > > Cheers, > Severin > > On Thu, 2021-04-29 at 17:24 +0200, Severin Gehwolf wrote:

Re: Ping? [8u] RFR: 8206925: Support the certificate_authorities extension

2021-05-10 Thread Severin Gehwolf
Hi! Would anyone be willing to review this? Many thanks in advance! Cheers, Severin On Thu, 2021-04-29 at 17:24 +0200, Severin Gehwolf wrote: > Anyone? > > On Tue, 2021-04-20 at 12:23 +0200, Severin Gehwolf wrote: > > Hi, > > > > Please review this OpenJDK 8u backport of the > > certificate_a

Re: RFR: 8164804: sun/security/ssl/SSLSocketImpl/CloseSocket.java makes not reliable time assumption [v2]

2021-05-10 Thread Julia Boes
On Wed, 5 May 2021 10:08:15 GMT, Fernando Guallini wrote: >> test sun/security/ssl/SSLSocketImpl/CloseSocket.java verifies the behavior >> when a server closes the socket connection during a handshake. The server >> was waiting a fixed 100ms before closing it, but there was no guarantee that

Integrated: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)

2021-05-10 Thread Alexey Bakhtin
On Fri, 23 Apr 2021 20:51:19 GMT, Alexey Bakhtin wrote: > Hello All, > > Could you please review the fix for the JDK-8241248? > The issue happens during the TLSv1.3 handshake without server stateless > session resumption in case of server receives several parallel requests with > the same pre_