Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v10]

2021-07-06 Thread Yi Yang
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex > by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in > the whole JDK codebase. Yi Yang has updated the pull request incrementally with two additional commits since the last revision: - re

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v9]

2021-07-06 Thread Yi Yang
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex > by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in > the whole JDK codebase. Yi Yang has updated the pull request incrementally with four additional commits since the last revision: - r

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v8]

2021-07-06 Thread Yi Yang
On Tue, 6 Jul 2021 19:06:43 GMT, Mandy Chung wrote: >> Yi Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> tests rely on IOOBE exception message > > test/jdk/java/lang/StringBuffer/Exceptions.java line 73: > >> 71: n

Re: RFR: 8269827: JMH tests for AES/GCM byte[] and bytebuffers [v3]

2021-07-06 Thread Anthony Scarpino
> Hi, > > I need a review of these new jmh tests that run AES/GCM encryption and > decryption using byte[], heap bytebuffers, and direct bytebuffers as input > and output buffers for single and multi-part testing. > > thanks > > Tony Anthony Scarpino has updated the pull request incrementall

Re: RFR: 8269827: JMH tests for AES/GCM byte[] and bytebuffers [v2]

2021-07-06 Thread Eric Caspole
On Fri, 2 Jul 2021 23:30:17 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review of these new jmh tests that run AES/GCM encryption and >> decryption using byte[], heap bytebuffers, and direct bytebuffers as input >> and output buffers for single and multi-part testing. >> >> thanks >>

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v8]

2021-07-06 Thread Mandy Chung
On Wed, 23 Jun 2021 03:54:55 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has updated the pull request incrementally

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible

2021-07-06 Thread Mandy Chung
On Mon, 5 Jul 2021 06:29:58 GMT, David Holmes wrote: >> @dholmes-ora @AlanBateman @PaulSandoz do you have any comments on the latest >> version? Thanks. > > @kelthuzadx I did not see any response to my query about the change in > initialization (not load) order. I also remain concerned about i

Re: RFR: 8269827: JMH tests for AES/GCM byte[] and bytebuffers [v2]

2021-07-06 Thread Anthony Scarpino
On Tue, 6 Jul 2021 15:40:09 GMT, Weijun Wang wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> merge AESGCMByteArray with existing AESGCMBench > > test/micro/org/openjdk/bench/javax/crypto/full/AESGCMByteBuffer.j

Re: RFR: 8269827: JMH tests for AES/GCM byte[] and bytebuffers [v2]

2021-07-06 Thread Anthony Scarpino
On Tue, 6 Jul 2021 15:38:20 GMT, Weijun Wang wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> merge AESGCMByteArray with existing AESGCMBench > > test/micro/org/openjdk/bench/javax/crypto/full/AESGCMBench.java l

Re: RFR: 8269827: JMH tests for AES/GCM byte[] and bytebuffers [v2]

2021-07-06 Thread Anthony Scarpino
On Tue, 6 Jul 2021 15:41:27 GMT, Weijun Wang wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> merge AESGCMByteArray with existing AESGCMBench > > test/micro/org/openjdk/bench/javax/crypto/full/AESGCMBench.java l

Re: RFR: 8268965: TCP Connection Reset when connecting simple socket to SSL server

2021-07-06 Thread Xue-Lei Andrew Fan
On Thu, 17 Jun 2021 13:20:54 GMT, Alexey Bakhtin wrote: > Please review the fix for JDK-8268965. > > The new jtreg test is added for the described issue. > sun/security/ssl and javax/net/ssl tests are passed Hi Alexey, Thank you for the details thread stacks. The basic idea of the fix looks g

Re: RFR: 8269827: JMH tests for AES/GCM byte[] and bytebuffers [v2]

2021-07-06 Thread Weijun Wang
On Fri, 2 Jul 2021 23:30:17 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review of these new jmh tests that run AES/GCM encryption and >> decryption using byte[], heap bytebuffers, and direct bytebuffers as input >> and output buffers for single and multi-part testing. >> >> thanks >>

Re: RFR: 8268965: TCP Connection Reset when connecting simple socket to SSL server

2021-07-06 Thread Alexey Bakhtin
On Thu, 17 Jun 2021 13:20:54 GMT, Alexey Bakhtin wrote: > Please review the fix for JDK-8268965. > > The new jtreg test is added for the described issue. > sun/security/ssl and javax/net/ssl tests are passed Hi Xuelei, Thank you for your interest in this issue. In this particular test case, a s