Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.base [v11]

2021-07-07 Thread Yi Yang
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex > by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in > the whole JDK codebase. Yi Yang has refreshed the contents of this pull request, and previous commits have been removed. The increment

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.base [v8]

2021-07-07 Thread Yi Yang
On Wed, 7 Jul 2021 17:08:19 GMT, Mandy Chung wrote: >>> Does "client changes" means changes involving src/java.desktop and >>> test/java/awt? >> >> src/java.desktop, test/java/awt, and test/javax/imageio > >> > src/java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java >> > nee

Re: RFR: 8268965: TCP Connection Reset when connecting simple socket to SSL server [v2]

2021-07-07 Thread Alexey Bakhtin
On Wed, 7 Jul 2021 17:22:07 GMT, Xue-Lei Andrew Fan wrote: >> Alexey Bakhtin has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add read lock for inputRecord.deplete > > src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java line 1

Re: RFR: 8268965: TCP Connection Reset when connecting simple socket to SSL server [v3]

2021-07-07 Thread Alexey Bakhtin
> Please review the fix for JDK-8268965. > > The new jtreg test is added for the described issue. > sun/security/ssl and javax/net/ssl tests are passed Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: Use tryLock - Cha

Re: RFR: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support

2021-07-07 Thread Rajan Halade
On Wed, 7 Jul 2021 15:23:09 GMT, Fernando Guallini wrote: > test/jdk/javax/net/ssl/compatibility/JdkInfo is a helper class for the > compatibility tests. It is verifying whether a protocol or cipher suite is > supported/enabled by setting all the allowed values as a string, and then > invokin

Re: RFR: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support

2021-07-07 Thread Xue-Lei Andrew Fan
On Wed, 7 Jul 2021 15:23:09 GMT, Fernando Guallini wrote: > test/jdk/javax/net/ssl/compatibility/JdkInfo is a helper class for the > compatibility tests. It is verifying whether a protocol or cipher suite is > supported/enabled by setting all the allowed values as a string, and then > invokin

Re: RFR: 8268965: TCP Connection Reset when connecting simple socket to SSL server [v2]

2021-07-07 Thread Xue-Lei Andrew Fan
On Wed, 7 Jul 2021 10:15:19 GMT, Alexey Bakhtin wrote: >> Please review the fix for JDK-8268965. >> >> The new jtreg test is added for the described issue. >> sun/security/ssl and javax/net/ssl tests are passed > > Alexey Bakhtin has updated the pull request incrementally with one additional >

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v8]

2021-07-07 Thread Mandy Chung
On Wed, 7 Jul 2021 16:22:25 GMT, Mandy Chung wrote: >> Hi Mandy, thanks for reviewing this. >> >>> I suggest to separate the client changes (both src and test) in a separate >>> PR for the client review. >> >> Does "client changes" means changes involving src/java.desktop and >> test/java/aw

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v8]

2021-07-07 Thread Mandy Chung
On Wed, 7 Jul 2021 02:10:10 GMT, Yi Yang wrote: > Does "client changes" means changes involving src/java.desktop and > test/java/awt? src/java.desktop, test/java/awt, and test/javax/imageio - PR: https://git.openjdk.java.net/jdk/pull/4507

RFR: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support

2021-07-07 Thread Fernando Guallini
test/jdk/javax/net/ssl/compatibility/JdkInfo is a helper class for the compatibility tests. It is verifying whether a protocol or cipher suite is supported/enabled by setting all the allowed values as a string, and then invoking String contains() to return whether a specific version is supported

Re: RFR: 8268965: TCP Connection Reset when connecting simple socket to SSL server [v2]

2021-07-07 Thread Alexey Bakhtin
On Wed, 7 Jul 2021 10:15:19 GMT, Alexey Bakhtin wrote: >> Please review the fix for JDK-8268965. >> >> The new jtreg test is added for the described issue. >> sun/security/ssl and javax/net/ssl tests are passed > > Alexey Bakhtin has updated the pull request incrementally with one additional >

Re: RFR: 8268965: TCP Connection Reset when connecting simple socket to SSL server [v2]

2021-07-07 Thread Alexey Bakhtin
> Please review the fix for JDK-8268965. > > The new jtreg test is added for the described issue. > sun/security/ssl and javax/net/ssl tests are passed Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: Add read lock for inputRecord.d