Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.base [v11]

2021-07-08 Thread Mandy Chung
On Thu, 8 Jul 2021 03:12:24 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has refreshed the contents of this pull req

Re: [jdk17] RFR: 8268965: TCP Connection Reset when connecting simple socket to SSL server

2021-07-08 Thread Xue-Lei Andrew Fan
On Thu, 8 Jul 2021 21:11:54 GMT, Alexey Bakhtin wrote: > The original patch applies clean. > Test passed. Marked as reviewed by xuelei (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/236

[jdk17] RFR: 8268965: TCP Connection Reset when connecting simple socket to SSL server

2021-07-08 Thread Alexey Bakhtin
The original patch applies clean. Test passed. - Commit messages: - Backport 6f171b9f0d28ad17b31a54bad894f38d19df6f73 Changes: https://git.openjdk.java.net/jdk17/pull/236/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=236&range=00 Issue: https://bugs.openjdk.java.n

Re: [jdk17] RFR: 8266345: (fs) Custom DefaultFileSystemProvider security related loops

2021-07-08 Thread Brian Burkhalter
On Thu, 8 Jul 2021 18:21:31 GMT, Sean Mullan wrote: > Please review this fix to use the platform's default file system to avoid > recursive policy initialization > issues when a SecurityManager is enabled and the VM is configured to use a > custom file system provider. Looks good. ---

[jdk17] RFR: 8266345: (fs) Custom DefaultFileSystemProvider security related loops

2021-07-08 Thread Sean Mullan
Please review this fix to use the platform's default file system to avoid recursive policy initialization issues when a SecurityManager is enabled and the VM is configured to use a custom file system provider. - Commit messages: - 8266345: (fs) Custom DefaultFileSystemProvider secu

Integrated: 8269827: JMH tests for AES/GCM byte[] and bytebuffers

2021-07-08 Thread Anthony Scarpino
On Fri, 2 Jul 2021 19:13:48 GMT, Anthony Scarpino wrote: > Hi, > > I need a review of these new jmh tests that run AES/GCM encryption and > decryption using byte[], heap bytebuffers, and direct bytebuffers as input > and output buffers for single and multi-part testing. > > thanks > > Tony

Integrated: 8268965: TCP Connection Reset when connecting simple socket to SSL server

2021-07-08 Thread Alexey Bakhtin
On Thu, 17 Jun 2021 13:20:54 GMT, Alexey Bakhtin wrote: > Please review the fix for JDK-8268965. > > The new jtreg test is added for the described issue. > sun/security/ssl and javax/net/ssl tests are passed This pull request has now been integrated. Changeset: 6f171b9f Author:Alexey Bakht

Re: RFR: 8268965: TCP Connection Reset when connecting simple socket to SSL server [v3]

2021-07-08 Thread Xue-Lei Andrew Fan
On Wed, 7 Jul 2021 20:44:25 GMT, Alexey Bakhtin wrote: >> Please review the fix for JDK-8268965. >> >> The new jtreg test is added for the described issue. >> sun/security/ssl and javax/net/ssl tests are passed > > Alexey Bakhtin has updated the pull request incrementally with one additional >

Re: RFR: 8269827: JMH tests for AES/GCM byte[] and bytebuffers [v3]

2021-07-08 Thread Anthony Scarpino
On Thu, 8 Jul 2021 14:39:20 GMT, Weijun Wang wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add small.AESGCMByteBuffer and fix dataSize > > test/micro/org/openjdk/bench/javax/crypto/full/AESGCMByteBuffer.java

Re: RFR: 8269827: JMH tests for AES/GCM byte[] and bytebuffers [v4]

2021-07-08 Thread Anthony Scarpino
> Hi, > > I need a review of these new jmh tests that run AES/GCM encryption and > decryption using byte[], heap bytebuffers, and direct bytebuffers as input > and output buffers for single and multi-part testing. > > thanks > > Tony Anthony Scarpino has updated the pull request incrementall

Re: RFR: 8269827: JMH tests for AES/GCM byte[] and bytebuffers [v3]

2021-07-08 Thread Weijun Wang
On Tue, 6 Jul 2021 23:06:39 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review of these new jmh tests that run AES/GCM encryption and >> decryption using byte[], heap bytebuffers, and direct bytebuffers as input >> and output buffers for single and multi-part testing. >> >> thanks >>