Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.base [v11]

2021-07-12 Thread Yi Yang
On Thu, 8 Jul 2021 03:12:24 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has refreshed the contents of this pull req

Integrated: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.base

2021-07-12 Thread Yi Yang
On Wed, 16 Jun 2021 08:08:47 GMT, Yi Yang wrote: > After JDK-8265518(#3615), it's possible to replace all variants of checkIndex > by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in > the whole JDK codebase. This pull request has now been integrated. Changeset: afe95

RFR: Merge jdk17

2021-07-12 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8266345: (fs) Custom DefaultFileSystemProvider security related loops - 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field - 8268965: TCP Connection Reset when connecting simple socket to SSL se

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.base [v11]

2021-07-12 Thread Roger Riggs
On Thu, 8 Jul 2021 03:12:24 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has refreshed the contents of this pull req

Re: RFR: 8267086: Fix ArrayIndexOutOfBoundsException in DerIndefLenConverter

2021-07-12 Thread Fabian Meumertzheim
On Mon, 12 Jul 2021 17:52:58 GMT, Xue-Lei Andrew Fan wrote: >> The referenced bug is >> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8267086, but for some >> reason the reference is shown as not valid. > > @fmeum Did you want to re-open this PR request? I will have a look at the PR. @

Re: RFR: 8267086: Fix ArrayIndexOutOfBoundsException in DerIndefLenConverter

2021-07-12 Thread Xue-Lei Andrew Fan
On Mon, 17 May 2021 12:46:31 GMT, Fabian Meumertzheim wrote: >> `sun.security.util.DerIndefLenConverter#convertBytes` does not perform >> sufficient checks after calling `#parseValue`, which can overflow `dataPos` >> or make it exceed `dataSize`. This can lead to an >> `ArrayIndexOutOfBoundsE

Withdrawn: 8267086: Fix ArrayIndexOutOfBoundsException in DerIndefLenConverter

2021-07-12 Thread duke
On Mon, 17 May 2021 12:33:53 GMT, Fabian Meumertzheim wrote: > `sun.security.util.DerIndefLenConverter#convertBytes` does not perform > sufficient checks after calling `#parseValue`, which can overflow `dataPos` > or make it exceed `dataSize`. This can lead to an > `ArrayIndexOutOfBoundsExcep

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.base [v11]

2021-07-12 Thread Mandy Chung
On Mon, 12 Jul 2021 05:21:34 GMT, Yi Yang wrote: > I'm not familiar with the review process of core-lib group. Is it sufficient > for merging with one approval? Should I have more reviews for this? 🤔 It depends on the change. For this patch, it's good to get another reviewer to look through it

[jdk17] Integrated: 8266345: (fs) Custom DefaultFileSystemProvider security related loops

2021-07-12 Thread Sean Mullan
On Thu, 8 Jul 2021 18:21:31 GMT, Sean Mullan wrote: > Please review this fix to use the platform's default file system to avoid > recursive policy initialization > issues when a SecurityManager is enabled and the VM is configured to use a > custom file system provider. This pull request has no

Re: [jdk17] RFR: 8266345: (fs) Custom DefaultFileSystemProvider security related loops

2021-07-12 Thread Chris Hegarty
On Thu, 8 Jul 2021 18:21:31 GMT, Sean Mullan wrote: > Please review this fix to use the platform's default file system to avoid > recursive policy initialization > issues when a SecurityManager is enabled and the VM is configured to use a > custom file system provider. Marked as reviewed by ch

[jdk17] Integrated: 8268965: TCP Connection Reset when connecting simple socket to SSL server

2021-07-12 Thread Alexey Bakhtin
On Thu, 8 Jul 2021 21:11:54 GMT, Alexey Bakhtin wrote: > The original patch applies clean. > Test passed. This pull request has now been integrated. Changeset: e1d3e73d Author:Alexey Bakhtin Committer: Vladimir Kempik URL: https://git.openjdk.java.net/jdk17/commit/e1d3e73d4ee32fac7