Re: RFR: 8271566: DSA signature length value is not accurate in P11Signature [v2]

2021-08-17 Thread Valerie Peng
On Fri, 13 Aug 2021 17:11:45 GMT, Martin Balao wrote: >> As described in JDK-8271566 [1], this patch proposal is intended to fix a >> problem that arises when using DSA keys that have a 256-bits (or larger) G >> parameter for signatures (either signing or verifying). There were some >> incorre

Re: RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v10]

2021-08-17 Thread Vladimir Kozlov
On Tue, 17 Aug 2021 23:37:55 GMT, Smita Kamath wrote: >> I would like to submit AES-GCM optimization for x86_64 architectures >> supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES >> and GHASH operations. >> Performance gain of ~1.5x - 2x for message sizes 8k and above.

Re: RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v10]

2021-08-17 Thread Vladimir Kozlov
On Tue, 17 Aug 2021 23:37:55 GMT, Smita Kamath wrote: >> I would like to submit AES-GCM optimization for x86_64 architectures >> supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES >> and GHASH operations. >> Performance gain of ~1.5x - 2x for message sizes 8k and above.

Re: RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v10]

2021-08-17 Thread Smita Kamath
> I would like to submit AES-GCM optimization for x86_64 architectures > supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES > and GHASH operations. > Performance gain of ~1.5x - 2x for message sizes 8k and above. Smita Kamath has updated the pull request incrementally wit

Re: Logging missing keytab file in Krb5LoginModule

2021-08-17 Thread Wei-Jun Wang
How do you think if we add some debug info at the internal KeyTab creation at [1]? For the 2 exceptions we can print out a line and the exception.toString(), then you will know if the filename doesn’t exist, or is a directory, or no permission to read. Of course, you will need to turn on -Dsun

Logging missing keytab file in Krb5LoginModule

2021-08-17 Thread Horváth Péter Gergely
Dear All, I am wondering if someone would be kind enough to sponsor the following small change: When debugging is enabled for com.sun.security.auth.module.Krb5LoginModule and the file specified by "keyTab" is not found, Krb5LoginModule simply emits a generic message, similar to this: "Key for the

Integrated: 8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182

2021-08-17 Thread Abdul Kolarkunnu
On Tue, 17 Aug 2021 15:58:49 GMT, Abdul Kolarkunnu wrote: > MultipleLogins.sh compiles all files under lib/jdk/test/lib/artifacts, Since > JDK-8266182 added a new file OpensslArtifactFetcher.java in to same package > and it has dependency with some other library files > jdk.test.lib.process.

Re: RFR: 8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182

2021-08-17 Thread Weijun Wang
On Tue, 17 Aug 2021 15:58:49 GMT, Abdul Kolarkunnu wrote: > MultipleLogins.sh compiles all files under lib/jdk/test/lib/artifacts, Since > JDK-8266182 added a new file OpensslArtifactFetcher.java in to same package > and it has dependency with some other library files > jdk.test.lib.process.

RFR: 8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182

2021-08-17 Thread Abdul Kolarkunnu
MultipleLogins.sh compiles all files under lib/jdk/test/lib/artifacts, Since JDK-8266182 added a new file OpensslArtifactFetcher.java in to same package and it has dependency with some other library files jdk.test.lib.process.ProcessTools & jdk.test.lib.Platform. These libraries are not there

Integrated: 8225083: Remove Google certificate that is expiring in December 2021

2021-08-17 Thread Rajan Halade
On Tue, 17 Aug 2021 03:59:15 GMT, Rajan Halade wrote: > Removed the expiring root certificate. This pull request has now been integrated. Changeset: 1cbf41a8 Author:Rajan Halade URL: https://git.openjdk.java.net/jdk/commit/1cbf41a87b153c010c51fdbae832e00314422193 Stats: 34 lines

Re: RFR: 8225083: Remove Google certificate that is expiring in December 2021

2021-08-17 Thread Sean Mullan
On Tue, 17 Aug 2021 03:59:15 GMT, Rajan Halade wrote: > Removed the expiring root certificate. Marked as reviewed by mullan (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5137

Integrated: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java

2021-08-17 Thread Abdul Kolarkunnu
On Tue, 8 Jun 2021 16:00:11 GMT, Abdul Kolarkunnu wrote: > ParamsTest is an interop test between keytool <-> openssl. There are some > manual steps listed in jdk/sun/security/pkcs12/params/README to perform after > the execution of jtreg execution. So this test is to perform that manual > ste

Re: RFR: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java [v8]

2021-08-17 Thread Abdul Kolarkunnu
> ParamsTest is an interop test between keytool <-> openssl. There are some > manual steps listed in jdk/sun/security/pkcs12/params/README to perform after > the execution of jtreg execution. So this test is to perform that manual > steps. Abdul Kolarkunnu has updated the pull request increment

Re: RFR: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java [v7]

2021-08-17 Thread Abdul Kolarkunnu
On Tue, 17 Aug 2021 11:58:30 GMT, Weijun Wang wrote: >> Abdul Kolarkunnu has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8266182: Automate manual steps listed in the test >> jdk/sun/security/pkcs12/ParamsTest.java > > test/lib/jdk/test/

Re: RFR: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java [v7]

2021-08-17 Thread Weijun Wang
On Tue, 17 Aug 2021 11:33:07 GMT, Abdul Kolarkunnu wrote: >> ParamsTest is an interop test between keytool <-> openssl. There are some >> manual steps listed in jdk/sun/security/pkcs12/params/README to perform >> after the execution of jtreg execution. So this test is to perform that >> manua

Re: RFR: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java [v6]

2021-08-17 Thread Abdul Kolarkunnu
On Fri, 13 Aug 2021 15:30:26 GMT, Weijun Wang wrote: >> Abdul Kolarkunnu has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8266182: Automate manual steps listed in the test >> jdk/sun/security/pkcs12/ParamsTest.java > > test/jdk/sun/secur

Re: RFR: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java [v7]

2021-08-17 Thread Abdul Kolarkunnu
> ParamsTest is an interop test between keytool <-> openssl. There are some > manual steps listed in jdk/sun/security/pkcs12/params/README to perform after > the execution of jtreg execution. So this test is to perform that manual > steps. Abdul Kolarkunnu has updated the pull request increment