Re: RFR: 8246797: A convenient method to read OPTIONAL element [v2]

2021-08-25 Thread Valerie Peng
On Tue, 24 Aug 2021 18:05:50 GMT, Weijun Wang wrote: >> src/java.base/share/classes/sun/security/util/DerInputStream.java line 352: >> >>> 350: * @throws IOException if an I/O error happens while peeking the >>> byte >>> 351: */ >>> 352: public boolean seeOptionalContextSpecific(i

Re: RFR: 8272863: Replace usages of Collections.sort with List.sort call in public java modules [v3]

2021-08-25 Thread Andrey Turbanov
> Collections.sort is just a wrapper, so it is better to use an instance method > directly. Andrey Turbanov has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. -

Re: RFR: 8272863: Replace usages of Collections.sort with List.sort call in public java modules [v2]

2021-08-25 Thread Alexander Zvegintsev
On Wed, 25 Aug 2021 12:47:41 GMT, Andrey Turbanov wrote: >> src/java.base/share/classes/java/net/URLPermission.java line 222: >> >>> 220: >>> 221: List l = normalizeMethods(methods); >>> 222: l.sort(null); >> >> I am not opposed to this change, but I find this is slightly more

Re: RFR: 8272863: Replace usages of Collections.sort with List.sort call in public java modules [v2]

2021-08-25 Thread Andrey Turbanov
On Wed, 25 Aug 2021 08:29:57 GMT, Daniel Fuchs wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8272863: Replace usages of Collections.sort with List.sort call in public >> java modules >> replace Collections.

Re: JDK-8129988 introduces a new behavior when reading the javax.net.ssl.trustStore property.

2021-08-25 Thread Volker Simonis
Hi, I'd like to resurrect this old discussion which seems to have got lost. David has analyzed and described the behavioral differences introduced by JDK-8219988 around the handling of the "javax.net.ssl.trustStore" property pretty well in his initial mail (see below). The main difference is tha

Re: RFR: 8272863: Replace usages of Collections.sort with List.sort call in public java modules [v2]

2021-08-25 Thread Daniel Fuchs
On Tue, 24 Aug 2021 20:21:52 GMT, Andrey Turbanov wrote: >> Collections.sort is just a wrapper, so it is better to use an instance >> method directly. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8272863: Replace us