Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v3]

2021-10-15 Thread Daniel Fuchs
On Tue, 12 Oct 2021 15:43:24 GMT, Aleksei Efimov wrote: >> This change implements a new service provider interface for host name and >> address resolution, so that java.net.InetAddress API can make use of >> resolvers other than the platform's built-in resolver. >> >> The following API classes

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v5]

2021-10-15 Thread Maurizio Cimadamore
On Fri, 15 Oct 2021 16:54:58 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-419 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjd

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v5]

2021-10-15 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull request

Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v3]

2021-10-15 Thread Daniel Fuchs
On Tue, 12 Oct 2021 15:43:24 GMT, Aleksei Efimov wrote: >> This change implements a new service provider interface for host name and >> address resolution, so that java.net.InetAddress API can make use of >> resolvers other than the platform's built-in resolver. >> >> The following API classes

Re: RFR: 8275252: Migrate cacerts from JKS to password-less PKCS12

2021-10-15 Thread Weijun Wang
On Fri, 15 Oct 2021 14:12:55 GMT, Magnus Ihse Bursie wrote: >> make/jdk/src/classes/build/tools/generatecacerts/GenerateCacerts.java line >> 74: >> >>> 72: cert = (X509Certificate) cf.generateCertificate(fis); >>> 73: } >>> 74: ks.setCertificateEntry(alia

Re: RFR: 8275252: Migrate cacerts from JKS to password-less PKCS12

2021-10-15 Thread Magnus Ihse Bursie
On Fri, 15 Oct 2021 14:02:15 GMT, Sean Mullan wrote: >> The cacerts file is now a password-less PKCS12 file. This make sure old code >> that uses a JKS KeyStore object can continuously load it using a null >> password (in fact, any password) and see all certificates inside. > > make/jdk/src/cla

Re: RFR: 8275252: Migrate cacerts from JKS to password-less PKCS12

2021-10-15 Thread Sean Mullan
On Thu, 14 Oct 2021 13:36:19 GMT, Weijun Wang wrote: > The cacerts file is now a password-less PKCS12 file. This make sure old code > that uses a JKS KeyStore object can continuously load it using a null > password (in fact, any password) and see all certificates inside. make/jdk/src/classes/b

Integrated: 8049520: FileCredentialsCache loads cache once and is never refreshed

2021-10-15 Thread Weijun Wang
On Thu, 14 Oct 2021 22:53:42 GMT, Weijun Wang wrote: > Just re-load the CredentialsCache like we did on non-Windows non-macOS > systems. This pull request has now been integrated. Changeset: 8e020642 Author:Weijun Wang URL: https://git.openjdk.java.net/jdk/commit/8e02064288a5954ab7

Re: RFR: 8272163: Add -version option to keytool and jarsigner

2021-10-15 Thread Weijun Wang
On Thu, 14 Oct 2021 16:04:08 GMT, Hai-May Chao wrote: > It'd be useful to have a -version option for keytool and jarsigner. Many > other JDK tools already have a -version option. This is to add -version > option to keytool and jarsigner like jar command does. > > CSR review: > https://bugs.ope

Re: RFR: 8049520: FileCredentialsCache loads cache once and is never refreshed [v2]

2021-10-15 Thread Sean Mullan
On Fri, 15 Oct 2021 13:29:19 GMT, Weijun Wang wrote: >> Just re-load the CredentialsCache like we did on non-Windows non-macOS >> systems. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > test info Marked as reviewed by mul

Re: RFR: 8049520: FileCredentialsCache loads cache once and is never refreshed [v2]

2021-10-15 Thread Weijun Wang
> Just re-load the CredentialsCache like we did on non-Windows non-macOS > systems. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: test info - Changes: - all: https://git.openjdk.java.net/jdk/pull/5960/files - new:

Re: RFR: 8049520: FileCredentialsCache loads cache once and is never refreshed [v2]

2021-10-15 Thread Weijun Wang
On Fri, 15 Oct 2021 12:54:37 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> test info > > test/jdk/sun/security/krb5/ccache/Refresh.java line 26: > >> 24: /* >> 25: * @test >> 26: * @bug 8028780

Re: RFR: 8272163: Add -version option to keytool and jarsigner

2021-10-15 Thread Sean Mullan
On Thu, 14 Oct 2021 16:04:08 GMT, Hai-May Chao wrote: > It'd be useful to have a -version option for keytool and jarsigner. Many > other JDK tools already have a -version option. This is to add -version > option to keytool and jarsigner like jar command does. > > CSR review: > https://bugs.ope

Re: RFR: JDK-8061729 : Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs [v2]

2021-10-15 Thread Daniel Fuchs
On Fri, 15 Oct 2021 12:38:14 GMT, Mahendra Chhipa wrote: >> There are some regression tests depending on sun.net.www.MessageHeader, the >> internal API dependency should be removed. Some of other internal API >> dependancies are removed in following issues : >> JDK-8273142 >> JDK-8268464 >> JDK

Re: RFR: JDK-8061729 : Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs [v2]

2021-10-15 Thread Daniel Fuchs
On Fri, 15 Oct 2021 12:38:14 GMT, Mahendra Chhipa wrote: >> There are some regression tests depending on sun.net.www.MessageHeader, the >> internal API dependency should be removed. Some of other internal API >> dependancies are removed in following issues : >> JDK-8273142 >> JDK-8268464 >> JDK

Re: RFR: 8049520: FileCredentialsCache loads cache once and is never refreshed

2021-10-15 Thread Sean Mullan
On Thu, 14 Oct 2021 22:53:42 GMT, Weijun Wang wrote: > Just re-load the CredentialsCache like we did on non-Windows non-macOS > systems. test/jdk/sun/security/krb5/ccache/Refresh.java line 2: > 1: /* > 2: * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. Year should be

Re: RFR: JDK-8061729 : Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs [v2]

2021-10-15 Thread Mahendra Chhipa
> There are some regression tests depending on sun.net.www.MessageHeader, the > internal API dependency should be removed. Some of other internal API > dependancies are removed in following issues : > JDK-8273142 > JDK-8268464 > JDK-8268133 Mahendra Chhipa has updated the pull request incrementa