Re: RFR: 8279903: Redundant modulo operation in ECDHKeyAgreement [v2]

2022-01-11 Thread John Jiang
> In class `sun.security.ec.ECDHKeyAgreement.java`, the last `mod()` in the > below line looks redundant, > > BigInteger lhs = y.modPow(BigInteger.valueOf(2), p).mod(p); John Jiang has updated the pull request incrementally with one additional commit since the last revision: update

RFR: 8279903: Redundant modulo operation in ECDHKeyAgreement

2022-01-11 Thread John Jiang
In class `sun.security.ec.ECDHKeyAgreement.java`, the last `mod()` in the below line looks redundant, BigInteger lhs = y.modPow(BigInteger.valueOf(2), p).mod(p); - Commit messages: - 8279903: Redundant modulo operation in ECDHKeyAgreement Changes:

Re: RFR: 8279800: isAssignableFrom checks in AlgorithmParametersSpi.engineGetParameterSpec appear to be backwards

2022-01-11 Thread Xue-Lei Andrew Fan
On Tue, 11 Jan 2022 20:38:30 GMT, Weijun Wang wrote: > Change the order so parent class is at the left. Hm, an interesting catch. I have a concern, although. src/java.base/share/classes/com/sun/crypto/provider/BlockCipherParamsCore.java line 111: > 109: T getParameterSpec(Class >

Re: RFR: 8279801: EC KeyFactory and KeyPairGenerator do not have aliases for OID format

2022-01-11 Thread Xue-Lei Andrew Fan
On Tue, 11 Jan 2022 20:34:59 GMT, Weijun Wang wrote: > Add OID aliases for the 2 service. This makes sure KeyFactory can be created > and read an encoded key without knowing what the OID in the encoding is for. It is not obvious about the description "Add OID aliases for the 2 service", but I

RFR: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints

2022-01-11 Thread Hai-May Chao
`keytool` currently uses a simpler scheme in `DisabledAlgorithmConstraints` class when performing algorithm constraints checks. This change is to enhance `keytool` to make use of the new methods `DisabledAlgorithmConstraints.permits` with `CertPathConstraintsParameters` and `checkKey`

Re: JEP 411: sandboxing use case

2022-01-11 Thread Sean Mullan
On 1/10/22 9:22 AM, Olivier Cailloux wrote: Dear list, I would like to share my use case for currently using the security manager mechanism (SM) in my software. Now that JEP 411 is there, any advice about any currently existing solution for replacement would be welcome, if this is already

RFR: 8279800: isAssignableFrom checks in AlgorithmParametersSpi.engineGetParameterSpec appear to be backwards

2022-01-11 Thread Weijun Wang
Change the order so parent class is at the left. - Commit messages: - 8279800: isAssignableFrom checks in AlgorithmParametersSpi.engineGetParameterSpec appear to be backwards Changes: https://git.openjdk.java.net/jdk/pull/7037/files Webrev:

RFR: 8279801: EC KeyFactory and KeyPairGenerator do not have aliases for OID format

2022-01-11 Thread Weijun Wang
Add OID aliases for the 2 service. This makes sure KeyFactory can be created and read an encoded key without knowing what the OID in the encoding is for. - Commit messages: - 8279801: EC KeyFactory and KeyPairGenerator do not have aliases for OID format Changes: