Integrated: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled

2022-02-02 Thread Xue-Lei Andrew Fan
On Tue, 25 Jan 2022 00:13:32 GMT, Xue-Lei Andrew Fan wrote: > A hostname in an URL ending with a dot is valid (See RFC 1034). However, it > is not a valid SNI hostname. The ending dot should be ignored while checking > the hostname with SNI or the name in a X.509 certificate. > > The update

Re: RFR: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled [v2]

2022-02-02 Thread Xue-Lei Andrew Fan
On Thu, 3 Feb 2022 01:19:12 GMT, Weijun Wang wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add regression test with customized hosts > > test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java line 8: > >

Re: RFR: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled [v3]

2022-02-02 Thread Xue-Lei Andrew Fan
> A hostname in an URL ending with a dot is valid (See RFC 1034). However, it > is not a valid SNI hostname. The ending dot should be ignored while checking > the hostname with SNI or the name in a X.509 certificate. > > The update could be verified with jshell. > $ $JDK_HOME/bin/jshell > jshe

Re: RFR: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled [v3]

2022-02-02 Thread Weijun Wang
On Thu, 3 Feb 2022 03:42:33 GMT, Xue-Lei Andrew Fan wrote: >> A hostname in an URL ending with a dot is valid (See RFC 1034). However, it >> is not a valid SNI hostname. The ending dot should be ignored while >> checking the hostname with SNI or the name in a X.509 certificate. >> >> The upd

Re: RFR: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled [v2]

2022-02-02 Thread Weijun Wang
On Wed, 26 Jan 2022 18:58:07 GMT, Xue-Lei Andrew Fan wrote: >> A hostname in an URL ending with a dot is valid (See RFC 1034). However, it >> is not a valid SNI hostname. The ending dot should be ignored while >> checking the hostname with SNI or the name in a X.509 certificate. >> >> The up

Re: RFR: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled [v2]

2022-02-02 Thread Xue-Lei Andrew Fan
On Wed, 26 Jan 2022 18:58:07 GMT, Xue-Lei Andrew Fan wrote: >> A hostname in an URL ending with a dot is valid (See RFC 1034). However, it >> is not a valid SNI hostname. The ending dot should be ignored while >> checking the hostname with SNI or the name in a X.509 certificate. >> >> The up

Re: RFR: 8272777: Clean up remaining AccessController warnings in test library

2022-02-02 Thread Serguei Spitsyn
On Wed, 2 Feb 2022 21:35:59 GMT, Kevin Walls wrote: > Reduce noise in test output by adding the @SuppressWarnings("removal") > annotation (which has already been widely applied). Marked as reviewed by sspitsyn (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7328

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-02 Thread Xue-Lei Andrew Fan
On Wed, 2 Feb 2022 22:13:07 GMT, Sean Mullan wrote: > On a related issue, have you given any thought as to what the behavior should > be if a 3rd-party JSSE provider is not updated to support these new methods? > I don't know of a good way to address that since the API is not part of the > pro

Withdrawn: 8280494: (D)TLS signature schemes

2022-02-02 Thread Xue-Lei Andrew Fan
On Thu, 27 Jan 2022 22:06:21 GMT, Xue-Lei Andrew Fan wrote: > This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-02 Thread Xue-Lei Andrew Fan
On Wed, 2 Feb 2022 19:12:56 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE: https://bugs.openjdk.java.net/browse/JDK-8

Re: RFR: 8272777: Clean up remaining AccessController warnings in test library

2022-02-02 Thread Roger Riggs
On Wed, 2 Feb 2022 21:35:59 GMT, Kevin Walls wrote: > Reduce noise in test output by adding the @SuppressWarnings("removal") > annotation (which has already been widely applied). Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7328

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-02 Thread Sean Mullan
On Wed, 2 Feb 2022 19:12:56 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE: https://bugs.openjdk.java.net/browse/JDK-8

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-02 Thread Sean Mullan
On Wed, 2 Feb 2022 19:12:56 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE: https://bugs.openjdk.java.net/browse/JDK-8

RFR: 8272777: Clean up remaining AccessController warnings in test library

2022-02-02 Thread Kevin Walls
Reduce noise in test output by adding the @SuppressWarnings("removal") annotation (which has already been widely applied). - Commit messages: - 8272777: Clean up remaining AccessController warnings in test library Changes: https://git.openjdk.java.net/jdk/pull/7328/files Webrev: h

Re: RFR: 8280494: (D)TLS signature schemes [v8]

2022-02-02 Thread Xue-Lei Andrew Fan
On Wed, 2 Feb 2022 14:45:21 GMT, Sean Mullan wrote: > A few more comments on the API. All good catches! Thank you very much. Updated the spec, CSR and impl. - PR: https://git.openjdk.java.net/jdk/pull/7252

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-02 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the pull request increment

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-02-02 Thread Sean Mullan
On Tue, 1 Feb 2022 06:42:30 GMT, Xue-Lei Andrew Fan wrote: >> Ok. You should specify what the default value of the signature schemes >> parameter is for this constructor as it does for the other parameters. > > Good catch. Updated. Looks good. - PR: https://git.openjdk.java.net/j

Re: RFR: 8280494: (D)TLS signature schemes [v8]

2022-02-02 Thread Sean Mullan
On Tue, 1 Feb 2022 06:47:00 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE: https://bugs.openjdk.java.net/browse/JDK-8