On Mon, 10 Jan 2022 13:36:25 GMT, Matthias Baesken wrote:
> 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java
> after 8278344
This pull request has now been integrated.
Changeset: 01f93ddf
Author:Matthias Baesken
URL:
https://git.openjdk.java.net/jdk18/comm
On Thu, 3 Feb 2022 21:30:59 GMT, Sean Mullan wrote:
> > > On a related issue, have you given any thought as to what the behavior
> > > should be if a 3rd-party JSSE provider is not updated to support these
> > > new methods? I don't know of a good way to address that since the API is
> > > not
On Thu, 20 Jan 2022 18:25:48 GMT, Andrey Turbanov wrote:
> Method `Provider.getKey` was added in
> [JDK-8276660](https://bugs.openjdk.java.net/browse/JDK-8276660). It was
> unused since introduction.
> Method `EngineDescription.getConstructorParameterClass()` and field
> `EngineDescription.con
> The option means there is no need to provide a password when loading a
> keystore. In some places in jarsigner and keytool, even with the option
> specified, password is still prompted for or warnings are still shown.
Weijun Wang has updated the pull request incrementally with one additional
On Wed, 2 Feb 2022 22:41:56 GMT, Xue-Lei Andrew Fan wrote:
> > On a related issue, have you given any thought as to what the behavior
> > should be if a 3rd-party JSSE provider is not updated to support these new
> > methods? I don't know of a good way to address that since the API is not
> >
On Thu, 3 Feb 2022 19:11:17 GMT, Hai-May Chao wrote:
> Code change looks good to me.
> I have a comment on the CSR. The “Options for jarsigner” section in
> `jarsigner` manpage, where it describes `-digestalg algorithm` and `-sigalg
> algorithm`, we would update it to include this new option `-
On Thu, 3 Feb 2022 18:32:42 GMT, Weijun Wang wrote:
>> Add the `-providerPath` option to jarsigner to be consistent with keytool.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> no need to append to null
Code change looks g
The option means there is no need to provide a password when loading a
keystore. In some places in jarsigner and keytool, even with the option
specified, password is still prompted for or warnings are still shown.
-
Commit messages:
- 8281234: The -protected option is not always ch
> Add the `-providerPath` option to jarsigner to be consistent with keytool.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
no need to append to null
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7338/files
On Thu, 3 Feb 2022 18:03:48 GMT, Xue-Lei Andrew Fan wrote:
>> Add the `-providerPath` option to jarsigner to be consistent with keytool.
>
> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line 256:
>
>> 254: String path = null;
>> 255:
On Thu, 3 Feb 2022 17:12:05 GMT, Weijun Wang wrote:
> Add the `-providerPath` option to jarsigner to be consistent with keytool.
Looks good to me except a minor comment. It's fine to me if you don't want to
take it.
src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line 256
Add the `-providerPath` option to jarsigner to be consistent with keytool.
-
Commit messages:
- 8281175: Add a -providerPath option to jarsigner
Changes: https://git.openjdk.java.net/jdk/pull/7338/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7338&range=00
Issue: ht
On Mon, 10 Jan 2022 13:36:25 GMT, Matthias Baesken wrote:
> 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java
> after 8278344
Marked as reviewed by xuelei (Reviewer).
-
PR: https://git.openjdk.java.net/jdk18/pull/91
On Mon, 10 Jan 2022 13:36:25 GMT, Matthias Baesken wrote:
> 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java
> after 8278344
Marked as reviewed by mullan (Reviewer).
-
PR: https://git.openjdk.java.net/jdk18/pull/91
> There are some regression tests depending on sun.net.www.MessageHeader, the
> internal API dependency should be removed. Some of other internal API
> dependancies are removed in following issues :
> JDK-8273142
> JDK-8268464
> JDK-8268133
Mahendra Chhipa has updated the pull request with a new
On Wed, 2 Feb 2022 21:35:59 GMT, Kevin Walls wrote:
> Reduce noise in test output by adding the @SuppressWarnings("removal")
> annotation (which has already been widely applied).
This pull request has now been integrated.
Changeset: 63a00a0d
Author:Kevin Walls
URL:
https://git.open
On Wed, 2 Feb 2022 21:35:59 GMT, Kevin Walls wrote:
> Reduce noise in test output by adding the @SuppressWarnings("removal")
> annotation (which has already been widely applied).
Thanks Roger and Serguei!
-
PR: https://git.openjdk.java.net/jdk/pull/7328
17 matches
Mail list logo
