Re: RFR: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName [v5]

2022-02-17 Thread Michael Osipov
On Thu, 17 Feb 2022 20:41:50 GMT, Weijun Wang wrote: >> @wangweij So you have selected to really swallow the exception here? > > Yes. I don't want to let the method fail. Since `instanceof String` should be > called anyway the caller can decide how to fail. So you leave it to the user to read t

Re: RFR: 8255266: 2021-11-27 public suffix list update v 3c213aa

2022-02-17 Thread Xue-Lei Andrew Fan
On Thu, 17 Feb 2022 23:28:35 GMT, Weijun Wang wrote: > Updating to a recent release of PSL. Marked as reviewed by xuelei (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7526

RFR: 8255266: 2021-11-27 public suffix list update v 3c213aa

2022-02-17 Thread Weijun Wang
Updating to a recent release of PSL. - Commit messages: - 8255266: 2021-11-27 public suffix list update v 3c213aa Changes: https://git.openjdk.java.net/jdk/pull/7526/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7526&range=00 Issue: https://bugs.openjdk.java.net/bro

Re: [External] Re: deprecation of SecurityManager JEP 411

2022-02-17 Thread Geertjan Wielenga
Unless there is a phone home mechanism built into the SecurityManager, nobody knows or can claim to know how widely the SecurityManager is being used. No, survey results don’t prove anything because people don’t fill in surveys. No, calls for people to report on their usage don’t mean anything in

Re: [External] Re: deprecation of SecurityManager JEP 411

2022-02-17 Thread arjan tijms
Hi, On Thu, Feb 17, 2022 at 5:45 PM Bowes, David wrote: > Your argument follows ’10,000 lemmings can’t be wrong’ > I didn't mean to say that the 10k lemmings are right. What I was trying to say is that the JDK team was making a tool that 10k-1 lemmings are not using. So for the 1 lemming

Re: RFR: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName [v5]

2022-02-17 Thread Weijun Wang
On Thu, 17 Feb 2022 19:42:30 GMT, Michael Osipov wrote: >> But in this case, we still have a place to provide the raw bytes. Maybe >> that's better? Or you'd rather be guaranteed that one particular otherName >> should always have a string there and there's no need to do an `instanceof` >> che

Re: RFR: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName [v5]

2022-02-17 Thread Michael Osipov
On Tue, 15 Feb 2022 15:55:50 GMT, Weijun Wang wrote: >> Correct, but they don't swallow at least. > > But in this case, we still have a place to provide the raw bytes. Maybe > that's better? Or you'd rather be guaranteed that one particular otherName > should always have a string there and ther

Re: RFR: 8280409: JarFile::verifiableEntry can fail with NPE accessing ze.getName() [v3]

2022-02-17 Thread Lance Andersen
On Fri, 11 Feb 2022 17:43:47 GMT, Lance Andersen wrote: >> src/java.base/share/classes/java/util/jar/JarFile.java line 881: >> >>> 879: ze = getJarEntry(entryName); >>> 880: } else { >>> 881: throw new ZipException("ZipEntry::getName returned null"); >> >> Throwi

Re: RFR: 8280409: JarFile::verifiableEntry can fail with NPE accessing ze.getName() [v4]

2022-02-17 Thread Lance Andersen
> Hi all, > > Please review the attached patch to address > > - That JarFile::getInputStream did not check for a null ZipEntry passed as a > parameter > - Have Zip/JarFile::getInputStream throw a ZipException in the event that an > unexpected exception occurs > > Mach5 tiers1-3 runs are clean

Re: RFR: 8280494: (D)TLS signature schemes [v18]

2022-02-17 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 > Release-note: https://bugs.openjdk.java.net/browse/JDK-8

Integrated: JDK-8282017 : sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server"

2022-02-17 Thread Mahendra Chhipa
On Thu, 17 Feb 2022 17:13:38 GMT, Mahendra Chhipa wrote: > Updated TunnelProxy to avoid twice read of Request line. This pull request has now been integrated. Changeset: cd9a3cf0 Author:Mahendra Chhipa Committer: Daniel Fuchs URL: https://git.openjdk.java.net/jdk/commit/cd9a3cf05b2

Withdrawn: 8282017: sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server"

2022-02-17 Thread Daniel Fuchs
On Wed, 16 Feb 2022 21:10:41 GMT, Daniel Fuchs wrote: > A seemingly innocuous change from > [JDK-8061729](https://bugs.openjdk.java.net/browse/JDK-8061729) is causing a > test failure. The fix is to simply revert that small change. This pull request has been closed without being integrated.

Re: RFR: 8282017: sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server" [v2]

2022-02-17 Thread Daniel Fuchs
On Wed, 16 Feb 2022 21:49:47 GMT, Daniel Fuchs wrote: >> A seemingly innocuous change from >> [JDK-8061729](https://bugs.openjdk.java.net/browse/JDK-8061729) is causing a >> test failure. The fix is to simply revert that small change. > > Daniel Fuchs has updated the pull request with a new ta

Re: RFR: JDK-8282017 : sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server"

2022-02-17 Thread Daniel Fuchs
On Thu, 17 Feb 2022 17:13:38 GMT, Mahendra Chhipa wrote: > Updated TunnelProxy to avoid twice read of Request line. Looks good to me Mahendra. I will withdraw my own PR. Just make sure to run the whole of tier2 :-) - Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjd

Re: RFR: JDK-8282017 : sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server"

2022-02-17 Thread Mahendra Chhipa
On Thu, 17 Feb 2022 17:13:38 GMT, Mahendra Chhipa wrote: > Updated TunnelProxy to avoid twice read of Request line. tier 2 mach5 Job : https://mach5.us.oracle.com/mdash/jobs/mahendrachhipa-jdk-20220217-1608-29227569 - PR: https://git.openjdk.java.net/jdk/pull/7519

RFR: JDK-8282017 : sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server"

2022-02-17 Thread Mahendra Chhipa
Updated TunnelProxy to avoid twice read of Request line. - Commit messages: - JDK-8282017 : sun/net/www/protocol/https/HttpsURLConnection/B6216082.java Changes: https://git.openjdk.java.net/jdk/pull/7519/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7519&range=00 Is

Re: RFR: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName [v6]

2022-02-17 Thread Weijun Wang
On Thu, 17 Feb 2022 15:36:23 GMT, Sean Mullan wrote: >> I thought about "the", but it does not show the belong to relation. > > What you can do is reword the sentence by including `otherName` in it, ex: "A > third entry may also be present in the list containing the {@code type-id} of > the oth

Re: RFR: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName [v8]

2022-02-17 Thread Weijun Wang
> The enhancement adds two extra items in the `getSubjectAlternativeNames()` > output for an OtherName. > > It also fix several errors: > 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]` > without the tag and length bytes. > 2. The argument in constructor `extClass.ge

Re: RFR: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName [v7]

2022-02-17 Thread Weijun Wang
> The enhancement adds two extra items in the `getSubjectAlternativeNames()` > output for an OtherName. > > It also fix several errors: > 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]` > without the tag and length bytes. > 2. The argument in constructor `extClass.ge

Re: RFR: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName [v6]

2022-02-17 Thread Sean Mullan
On Thu, 17 Feb 2022 03:07:54 GMT, Weijun Wang wrote: >> The whole paragraph uses plural forms like "IPv4 address names are" and "OID >> names are", so I also use "otherNames are" and "their". I admit I don't feel >> comfortable too. > > I thought about "the", but it does not show the belong to

Re: deprecation of SecurityManager JEP 411

2022-02-17 Thread arjan tijms
Hi, On Wed, Feb 16, 2022 at 6:24 PM Bowes, David wrote: > I used the SecurityManger with great success to protect against Log4JShell. > > > > [...] I would suggest that the SecurityManager does protect me from > singinficant threats. > While I don't disagree with you entirely, the problem is t